Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Fatal error: Cannot redeclare from() #8

Closed
umpirsky opened this issue May 18, 2015 · 2 comments
Closed

PHP Fatal error: Cannot redeclare from() #8

umpirsky opened this issue May 18, 2015 · 2 comments
Assignees
Labels

Comments

@umpirsky
Copy link

I tried to use https://github.com/hoaproject/Ruler and https://github.com/Athari/YaLinqo in same project.

composer install failed with:

PHP Fatal error:  Cannot redeclare from() (previously declared in vendor/hoa/core/Consistency.php:890) in vendor/athari/yalinqo/YaLinqo/Linq.php on line 21

There is obvious collision in from() function. Hoa checks if function exists, I guess YaLinqo should do the same.

@cursedcoder
Copy link

+1

@Athari
Copy link
Owner

Athari commented May 18, 2015

I don't like that it makes the code more fragile... I'd rather move the function into namespace, but use function is available only in PHP 5.6+. 😟 But adding this check won't hurt I guess.

@Athari Athari added the type:improvement Improvement label May 18, 2015
@Athari Athari self-assigned this May 18, 2015
@Athari Athari closed this as completed in 1c5c5c8 May 22, 2015
@Athari Athari added the resolved:done Done label May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants