Fix portal compatibility with XCM V5 upgrade #1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 195327a): https://astar-apps--pr1483-fix-xcm-v5-compatibi-akr8w45z.web.app (expires Tue, 22 Jul 2025 05:17:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
gtg7784
force-pushed
the
fix/xcm-v5-compatibility
branch
from
a1ded03 to
4300de7
Compare
- Add protected readonly xcmVersion property to base XcmRepository class - Replace all hardcoded 'V5' strings with dynamic this.xcmVersion references - Remove unnecessary intermediate version variable assignments - Enable version override capability for child repositories when needed This change provides a single source of truth for XCM version configuration, making future version updates easier and maintaining consistency across all XCM repository implementations.
gtg7784
force-pushed
the
fix/xcm-v5-compatibility
branch
from
dc8fe93 to
ce25960
Compare
* fix: updated XCM logix to apply V5 * fix: removed non-used endpoint * fix: updated Phala endpoint
impelcrypto
approved these changes
Jul 16, 2025
gtg7784
added a commit
that referenced
this pull request
Jul 16, 2025
Revert yarn.lock changes from PR #1483 that converted it to Yarn Berry format. This maintains compatibility with the existing Yarn v1 setup.
gtg7784
added a commit
that referenced
this pull request
Jul 16, 2025
Revert yarn.lock changes from PR #1483 that converted it to Yarn Berry format. This maintains compatibility with the existing Yarn v1 setup.
6 tasks
gtg7784
added a commit
that referenced
this pull request
Jul 16, 2025
Revert yarn.lock changes from PR #1483 that converted it to Yarn Berry format. This maintains compatibility with the existing Yarn v1 setup.
impelcrypto
added a commit
that referenced
this pull request
Jul 16, 2025
* Security issue fix (#1472) * Window open fix * Resize Astar (L1) connect button * hotfix: claim staking rewards from EVM wallet (#1474) * Change zkEVM RPC endpoint (#1457) * pin firebase-tools version to 13.35.1 in PR preview workflow (#1458) * pin firebase-tools version to 13.35.1 in PR preview workflow * pin firebase-tools version to 13.35.1 in staging deployment workflow * Enable unstake from unregistered (#1461) * Disable zk bridges and network selection (#1456) * Disable zk bridges and network selection * Hide network disabled comments * hotfix: removed zkEVM links (#1462) * feat: removed zkEVM links * feat: updated Astar button * fix: rollback * fix: removed unnecessary line (#1464) * Fix for available staking balance when user has tokens locked in governance (#1466) * fix: added extra 20% to the gaslimit * fix: clean up --------- Co-authored-by: Bobo <[email protected]> Co-authored-by: Taegeon Alan Go <[email protected]> * Fix for a bridge tooltip being partially hidden (#1473) * Fix for unstaking max amount (#1477) * Change unstake amount to bigint * Cleanup * Fix/maintenance mode modal (#1479) * Maintenance mode modal * Typo fix * Go Home * Maintenance modal go to assets link fix (#1480) * Fix for maintenance modal dark mode (#1482) * Fix portal compatibility with XCM V5 upgrade (#1483) * remove astar 2.0 and tech stack link (#1455) * Fix `fetchAssetConfigById` for XCM v5 compatibility * Update all XCM message constructions from V3 to V5 * refactor: centralize XCM version management in base repository - Add protected readonly xcmVersion property to base XcmRepository class - Replace all hardcoded 'V5' strings with dynamic this.xcmVersion references - Remove unnecessary intermediate version variable assignments - Enable version override capability for child repositories when needed This change provides a single source of truth for XCM version configuration, making future version updates easier and maintaining consistency across all XCM repository implementations. * update to keep using `V3` for Pendulum and Interlay * Update to set V5 only for Astar * fix: updated XCM logix to apply V5 for withdrawal transactions (#1485) * fix: updated XCM logix to apply V5 * fix: removed non-used endpoint * fix: updated Phala endpoint --------- Co-authored-by: Ayumi Takahashi <[email protected]> Co-authored-by: Roy <[email protected]> * hotfix: added a banner for Astar Snap deprecation (#1484) * feat: added a banner for Astar snap * fix: clean up * fix: refactoring * fix: increased minimum transfer amount for Bifrost assets (#1486) * revert: restore yarn.lock to Yarn v1 format (#1487) Revert yarn.lock changes from PR #1483 that converted it to Yarn Berry format. This maintains compatibility with the existing Yarn v1 setup. --------- Co-authored-by: Bobo <[email protected]> Co-authored-by: Taegeon Alan Go <[email protected]> Co-authored-by: Ayumi Takahashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Astar portal became incompatible with the XCM V5 upgrade that was deployed on May 9, 2025. The
fetchAssetConfigByIdmethod inXcmRepository.tswas hard-coded to access the.v3property from the chain response, but the chain now returns data in.v5format instead, causing the portal to fail when querying cross-chain asset configurations.Check list
This pull request makes the following changes:
Fixes
fetchAssetConfigByIdmethod to be version-agnostic by dynamically accessing the first available version key in the response object instead of hard-coding to a specific version..v3property access to dynamic version detectionImprovements
XcmRepositoryclass by adding aprotected readonly xcmVersion = 'V5'propertythis.xcmVersionreferencesChanges
fetchAssetConfigByIdto dynamically detect XCM version from chain responsexcmVersionproperty to base repository class