Move stake implementtion #1446
Merged
Move stake implementtion #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 605b6a5): https://astar-apps--pr1446-feat-move-stake-r9yjzoic.web.app (expires Fri, 07 Mar 2025 14:40:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
bobo-k2
requested review from
Kahonnohak,
codespool,
gtg7784 and
impelcrypto
Contributor
|
Contributor
|
hm I did try to leave 2ASTR and all tokens were moved after all but I did not see a notification for this. 
|
Contributor
Author
|
Nice catch. Fixed |
impelcrypto
added a commit
that referenced
this pull request
Mar 27, 2025
* feat: added ETH rebate banner (#1445) * feat: added rebate banner * fix: remove banner * feat: updated banner * ACS link (#1447) * ACS link * Tooltip fix * Fix for breaking change in runtime (#1449) * Move stake implementtion (#1446) * Logic implemented * Loosing bonus warning * EVM move and improved messages * Min stake check fix * Amount component bug fix * Remaining tokens bug fix * Styling updates * Min amount check fix * Min stake move warning * Enable staking tokens locked in democracy (#1451) * Locked in democracy to useBalance * Treat tokens locked in democracy as available for staking * fix: updated RPC (#1452) * Temporary disable unstake from unregistered call (#1454) --------- Co-authored-by: Bobo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Support for
move_stakeruntime call which enables unstaking from dApp A and staking to dApp B without loosing bonus.To initiate stake move go to Assets page and under My Dapps click Move icon for the dApp you want to move stakes from
Before we simulating move by unstaking from one and staking to another dApp. I replaced that logic with
move_stakecall.More info about the call can be found on links below
dAppStaking - Bonus rewards mechanism rework · Issue #1379 · AstarNetwork/Astar
feat(dAppStaking): Move actions for bonus rewards by Dinonard · Pull Request #1418 · AstarNetwork/Astar
Check list
This pull request makes the following changes: