refactor: centralize XCM version management in base repository

- Add protected readonly xcmVersion property to base XcmRepository class
- Replace all hardcoded 'V5' strings with dynamic this.xcmVersion references
- Remove unnecessary intermediate version variable assignments
- Enable version override capability for child repositories when needed

This change provides a single source of truth for XCM version configuration,
making future version updates easier and maintaining consistency across all
XCM repository implementations.

Author: gtg7784

package.json

@@ -4,6 +4,7 @@
   "description": "Astar Portal is the hub of a multi-chain, one-stop platform for managing assets and dApp Staking - build2earn protocol.",
   "productName": "Astar Portal - Astar & Shiden Network",
   "author": "Astar Network",
+  "private": false,
   "license": "GPL-3.0-only",
   "scripts": {
     "dev": "quasar dev",

src/v2/repositories/implementations/XcmRepository.ts

@@ -46,6 +46,9 @@ export const ASTAR_ADDRESS_PREFIX = 5;
 
 @injectable()
 export class XcmRepository implements IXcmRepository {
+  // XCM version to use for all message constructions
+  protected readonly xcmVersion = 'V5';
+  
   // Ids of Astar tokens on foreign network. To be initialized in iherited class.
   protected astarTokens: TokenId;
 
@@ -128,10 +131,9 @@ export class XcmRepository implements IXcmRepository {
       throw `Parachain id for ${to.name} is not defined`;
     }
 
-    const version = 'V5';
     // the target parachain connected to the current relaychain
     const destination = {
-      [version]: {
+      [this.xcmVersion]: {
         interior: {
           X1: {
             Parachain: new BN(to.parachainId),
@@ -149,7 +151,7 @@ export class XcmRepository implements IXcmRepository {
     };
 
     const beneficiary = {
-      [version]: {
+      [this.xcmVersion]: {
         interior: {
           X1: {
             AccountId32,
@@ -160,7 +162,7 @@ export class XcmRepository implements IXcmRepository {
     };
 
     const assets = {
-      [version]: [
+      [this.xcmVersion]: [
         {
           fun: {
             Fungible: amount,
@@ -210,7 +212,7 @@ export class XcmRepository implements IXcmRepository {
     };
 
     const assets = {
-      V5: {
+      [this.xcmVersion]: {
         fun: {
           Fungible: new BN(amount),
         },
@@ -219,7 +221,7 @@ export class XcmRepository implements IXcmRepository {
     };
 
     const destination = {
-      V5: {
+      [this.xcmVersion]: {
         interior: {
           X1: {
             AccountId32: {

src/v2/repositories/implementations/xcm/AcalaXcmRepository.ts

@@ -47,7 +47,7 @@ export class AcalaXcmRepository extends XcmRepository {
     const tokenData = this.getTokenData(token);
 
     const destination = {
-      V5: {
+      [this.xcmVersion]: {
         parents: '1',
         interior: {
           X2: [

src/v2/repositories/implementations/xcm/AstarXcmRepository.ts

@@ -50,7 +50,7 @@ export class AstarXcmRepository extends XcmRepository {
         };
 
     const assets = {
-      V5: {
+      [this.xcmVersion]: {
         fun: {
           Fungible: new BN(amount),
         },
@@ -73,7 +73,7 @@ export class AstarXcmRepository extends XcmRepository {
         };
 
     const destination = {
-      V5: {
+      [this.xcmVersion]: {
         interior: {
           X2: [
             {
@@ -97,7 +97,7 @@ export class AstarXcmRepository extends XcmRepository {
     if (feeAssetInformation.feeAssetIsRequired) {
       // we need to use another token for the fee
       const fee = {
-        V5: {
+        [this.xcmVersion]: {
           fun: {
             Fungible: new BN(feeAssetInformation.feeAmount),
           },

src/v2/repositories/implementations/xcm/BifrostXcmRepository.ts

@@ -58,14 +58,12 @@ export class BifrostXcmRepository extends XcmRepository {
       throw `Token name for ${token.originAssetId} is not defined`;
     }
 
-    const version = 'V5';
-
     const AccountId32 = {
       id: decodeAddress(recipientAddress),
     };
 
     const destination = {
-      [version]: {
+      [this.xcmVersion]: {
         parents: '1',
         interior: {
           X2: [

src/v2/repositories/implementations/xcm/HydrationXcmRepository.ts

@@ -43,14 +43,12 @@ export class HydrationXcmRepository extends XcmRepository {
       throw `Token name for ${token.originAssetId} is not defined`;
     }
 
-    const version = 'V5';
-
     const AccountId32 = {
       id: decodeAddress(recipientAddress),
     };
 
     const destination = {
-      [version]: {
+      [this.xcmVersion]: {
         parents: '1',
         interior: {
           X2: [

src/v2/repositories/implementations/xcm/InterlayXcmRepository.ts

@@ -35,7 +35,7 @@ export class InterlayXcmRepository extends XcmRepository {
     const tokenData = { Token: token.originAssetId };
 
     const destination = {
-      V5: {
+      [this.xcmVersion]: {
         parents: '1',
         interior: {
           X2: [

src/v2/repositories/implementations/xcm/PendulumXcmRepository.ts

@@ -40,14 +40,12 @@ export class PendulumXcmRepository extends XcmRepository {
       throw `Token name for ${token.originAssetId} is not defined`;
     }
 
-    const version = 'V5';
-
     const AccountId32 = {
       id: decodeAddress(recipientAddress),
     };
 
     const destination = {
-      [version]: {
+      [this.xcmVersion]: {
         parents: '1',
         interior: {
           X2: [

src/v2/repositories/implementations/xcm/StatemintXcmRepository.ts

@@ -35,9 +35,8 @@ export class StatemintXcmRepository extends XcmRepository {
       throw `Parachain id for ${to.name} is not defined`;
     }
 
-    const version = 'V5';
     const destination = {
-      [version]: {
+      [this.xcmVersion]: {
         interior: {
           X1: {
             Parachain: to.parachainId,
@@ -52,7 +51,7 @@ export class StatemintXcmRepository extends XcmRepository {
     };
 
     const beneficiary = {
-      [version]: {
+      [this.xcmVersion]: {
         interior: {
           X1: {
             AccountId32,
@@ -68,7 +67,7 @@ export class StatemintXcmRepository extends XcmRepository {
     const instance = 50;
 
     const assets = {
-      [version]: [
+      [this.xcmVersion]: [
         {
           fun: {
             Fungible: new BN(amount),