Skip to content

Fix string casemapping test #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

Fix string casemapping test #1525

merged 1 commit into from
Oct 27, 2020

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Oct 27, 2020

  • I've read the contributing guidelines

@MaxGraey MaxGraey requested a review from dcodeIO October 27, 2020 13:36
@dcodeIO
Copy link
Member

dcodeIO commented Oct 27, 2020

Just to confirm, I guess the problem was that codePointAt may return -1, so a signed type is needed?

@MaxGraey
Copy link
Member Author

MaxGraey commented Oct 27, 2020

Just to confirm, I guess the problem was that codePointAt may return -1, so a signed type is needed?

Yeah)

@dcodeIO dcodeIO merged commit e9982a9 into AssemblyScript:master Oct 27, 2020
@MaxGraey MaxGraey deleted the fix-string-cm-test branch October 27, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees

No one assigned

Labels

standard library tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO