Fixed Incorrect Callback Return in CLI Module Validation

[torch2424]

relates to DuncanUszkay1#14

Please see the PR above for the context. But TL;DR I was working on closures, and the tests would hang when failing when validating the module. I think this return is meant to happen outside of the measure.

With this fix, tests will not hang whenever a module cannot be validated correctly 😄 👍

cc @dcodeIO @MaxGraey

[dcodeIO]

Good catch! Perhaps let's make this an isValid var and throw the error / dispose if (!isValid)?

[torch2424]

That sounds good to me! 😄

[torch2424]

Oh wait, if I'm not mistaken we expect the callback to return a status code?

So it would be something like? 🤔 :

// Validate the module if requested
  if (!args.noValidate) {
    stats.validateCount++;
    let isValid;
    stats.validateTime += measure(() => {
      if (!module.validate()) {
        module.dispose();
        isValid = callback(Error("Validate error")) === 0;
      }
    });
    if (!isValid) {
      return 1;
    }
  }

cc @dcodeIO

[dcodeIO]

Something like the following maybe

if (!args.noValidate) {
  stats.validateCount++;
  let isValid;
  stats.validateTime += measure(() => {
    isValid = module.validate();
  });
  if (!isValid) {
    module.dispose();
    return callback(Error("validate error"));
  }
}

[dcodeIO]

Callback there is typically the default, unless one uses the CLI API. Returns 1 when an error is provided. The returned value becomes the exit code of asc.

[torch2424]

@dcodeIO Made requested changes! And I am pretty sure they work, as I forced some compiler errors (which I think would break validation), but it didn't hang 😄

[dcodeIO]

Great, thanks!

[github-actions]

🎉 This PR is included in version 0.13.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀