Enhance FunctionExpression type inference (#2458)

Co-authored-by: Max Graey <[email protected]>
Co-authored-by: dcode <[email protected]>

Author: 3 people

src/resolver.ts

@@ -2683,9 +2683,19 @@ export class Resolver extends DiagnosticEmitter {
     ) {
       // (x) => ret, infer return type accordingt to `ret`
       const expr = (<ExpressionStatement>body).expression;
-      const type = this.resolveExpression(expr, ctxFlow, ctxType, reportMode);
+      let signatureReference = assert(functionType.getSignature());
+      // create a temp flow to resolve expression
+      let tempFlow = Flow.createParent(ctxFlow.actualFunction);
+      let parameters = signature.parameters;
+      // return type of resolveFunctionType should have same parameter length with signature
+      assert(signatureReference.parameterTypes.length == parameters.length);
+      for (let i = 0, k = parameters.length; i < k; i++) {
+        const parameter = parameters[i];
+        const type = signatureReference.parameterTypes[i];
+        tempFlow.addScopedDummyLocal(parameter.name.text, type, parameter);
+      }
+      const type = this.resolveExpression(expr, tempFlow, ctxType, reportMode);
       if (type) {
-        let signatureReference = assert(functionType.getSignature());
         signatureReference.returnType = type;
       }
     }