Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate keys or values in base language file strings.xml or localization .strings are not reported will be good to have #30

Closed
AnilVarturi11 opened this issue Dec 23, 2021 · 3 comments · Fixed by #41

Comments

@AnilVarturi11
Copy link

No description provided.

@AnilVarturi11 AnilVarturi11 changed the title Duplicate keys or values in any of the file strings.xml or localization .strings are not reported will be good to have Duplicate keys or values in any of the language file strings.xml or localization .strings are not reported will be good to have Dec 23, 2021
@AnilVarturi11 AnilVarturi11 changed the title Duplicate keys or values in any of the language file strings.xml or localization .strings are not reported will be good to have Duplicate keys or values in base language file strings.xml or localization .strings are not reported will be good to have Dec 23, 2021
@stevelandeyasana
Copy link
Collaborator

Can you give an example of some strings that would have this problem?

@alex-hunsley-nl
Copy link

alex-hunsley-nl commented Sep 12, 2022

Just here to say +1 for this.

I'm just fixing a badly maintained localization file set and there are keys and values that are just outright duplicated:

"thing.key" = "hello there"
"thing.key" = "hello there"

But at the same time, you'd probably also like to detect:

"thing.key" = "hello there"
"thing.key" = "goodbye there"

i.e. a duplicated key regardless of values being different

@stevelandeyasana
Copy link
Collaborator

Thanks for the example! I opened a PR with an implementation. It'll be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants