Maybe we can upgrade datafusion to a version that can pass CI？

[zhuliquan]

Hello, I notice that arroyo upgrade datafusion to 43.0.0. But Arroyo datafusion doesn't pass CI, is't ok? Perhaps，we can upgrade datafision version which can pass CI.

[mwylde]

Are you referring to our fork https://github.com/ArroyoSystems/arrow-datafusion/tree/43.0.0/arroyo?

Unfortunately CI doesn't pass there because it requires access to apache CI resources. It's probably possible to get the CI in a better state but hasn't been a priority.

[zhuliquan]

Are you referring to our fork https://github.com/ArroyoSystems/arrow-datafusion/tree/43.0.0/arroyo?

Unfortunately CI doesn't pass there because it requires access to apache CI resources. It's probably possible to get the CI in a better state but hasn't been a priority.

Yeah, I refer it. But I looked at the following errors in the CI because there is the trait with a function that is not implemented. Is there something wrong with this?

error[E0046]: not all trait items implemented, missing: `reset`
   --> datafusion/ffi/src/execution_plan.rs:314:5
    |
314 |     impl ExecutionPlan for EmptyExec {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `reset` in implementation
    |
    = help: implement the missing item: `fn reset(&self) -> std::result::Result<(), datafusion::error::DataFusionError> { todo!() }`

error[E0046]: not all trait items implemented, missing: `reset`
  --> datafusion-examples/examples/composed_extension_codec.rs:99:1
   |
99 | impl ExecutionPlan for ParentExec {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `reset` in implementation
   |
   = help: implement the missing item: `fn reset(&self) -> Result<(), datafusion_common::DataFusionError> { todo!() }`

error[E0046]: not all trait items implemented, missing: `reset`
   --> datafusion-examples/examples/composed_extension_codec.rs:175:1
    |
175 | impl ExecutionPlan for ChildExec {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `reset` in implementation
    |
    = help: implement the missing item: `fn reset(&self) -> Result<(), datafusion_common::DataFusionError> { todo!() }`

[mwylde]

Ah, good point. The reset function is one we've added to the trait in our fork. It looks like CI is building examples, which don't get built when we use it as a dependency. That should be an easy fix.