-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Section 8 update #92
Section 8 update #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the new Domain Model there are some <<"use">> that seem to be misplaced, there are also some "comment blocks" that are in Spanish, I don't really get why you are doing this and it may need to be discussed by the team if we are to leave it that way. And to conclude, you have also re-formatted some code from different classes, I don't know if something has been changed, as some imports have been removed, so please check that this does not interfere with the applications functionality and that everything works as intended.
Obviously I will NOT leave it as it is. That is why is a DRAFT pull request and not a normal one. The imports deleted are colored in gray when they are not used in the code so it shouldn't affect the application. And the comments are there to show that I didn't find or whatever and I want help or your opinion about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the questions in the image:
- The api is supposed to be used by the map (to retrieve places).
- Category is a field of the places.
- PlaceType is not a class, it has to be either a type or an interface extending Document to work with mongoose (MongoDB).
After solving that, it would be nice, if possible, to change a bit the background color of the folders to see them better (the lines of the folders mix with those of the classes and associations and it is a bit difficult to distinguish everything.
Finally, although I understand this is not needed for now (as it would take some time), I think it is necessary to rearrange everything to minimize the number of crossed lines and position the items as tidy as possible.
Once you solve the initial remarks, it would be ok for me in this delivery.
@Davidmc07 which was the purpose of having a folder called place in the user POD? Are there the public places or what? |
# Conflicts: # webapp/src/adapters/solid/Assembler.ts # webapp/src/adapters/solid/PODManager.ts
The places folder contains the places created by the user. Their privacy level can be changed individually. |
Update of the crosscutting concepts of the documentation