diff --git a/.drone.yml b/.drone.yml index 8bcb9ee57d68c..04370afd1bd4e 100644 --- a/.drone.yml +++ b/.drone.yml @@ -64,7 +64,7 @@ pipeline: - Xvfb -screen 0 1024x768x24 -ac +extension GLX +render -noreset > /dev/null 2>&1 & - sleep 3 - fluxbox > /dev/null 2>&1 & - - cd /drone/src/github.com/joomla/joomla-cms && npm run lint:js + - npm run lint:js javascript-tests: image: joomlaprojects/docker-systemtests:develop diff --git a/administrator/components/com_admin/sql/updates/postgresql/3.9.0-2018-05-02.sql b/administrator/components/com_admin/sql/updates/postgresql/3.9.0-2018-05-02.sql index 04265c994e862..6aae953caff55 100644 --- a/administrator/components/com_admin/sql/updates/postgresql/3.9.0-2018-05-02.sql +++ b/administrator/components/com_admin/sql/updates/postgresql/3.9.0-2018-05-02.sql @@ -14,5 +14,5 @@ CREATE TABLE "#__privacy_requests" ( "user_id" bigint DEFAULT 0 NOT NULL, PRIMARY KEY ("id") ); -CREATE INDEX "#__fields_idx_checked_out" ON "#__privacy_requests" ("checked_out"); -CREATE INDEX "#__fields_idx_user_id" ON "#__privacy_requests" ("user_id"); +CREATE INDEX "#__privacy_requests_idx_checked_out" ON "#__privacy_requests" ("checked_out"); +CREATE INDEX "#__privacy_requests_idx_user_id" ON "#__privacy_requests" ("user_id"); diff --git a/administrator/components/com_config/tmpl/application/default_ftplogin.php b/administrator/components/com_config/tmpl/application/default_ftplogin.php index fa2e947078418..d5c610f45268a 100644 --- a/administrator/components/com_config/tmpl/application/default_ftplogin.php +++ b/administrator/components/com_config/tmpl/application/default_ftplogin.php @@ -7,11 +7,12 @@ * @license GNU General Public License version 2 or later; see LICENSE.txt */ +defined('_JEXEC') or die; + use Joomla\CMS\Language\Text; -defined('_JEXEC') or die; ?> -
+
ftp instanceof Exception) : ?> diff --git a/administrator/components/com_contact/tmpl/contact/edit.php b/administrator/components/com_contact/tmpl/contact/edit.php index 8ed6d80cfffbe..b89820c625289 100644 --- a/administrator/components/com_contact/tmpl/contact/edit.php +++ b/administrator/components/com_contact/tmpl/contact/edit.php @@ -80,7 +80,8 @@
- form->renderField('misc'); ?> + form->getLabel('misc'); ?> + form->getInput('misc'); ?>
diff --git a/administrator/components/com_contact/tmpl/contacts/default.php b/administrator/components/com_contact/tmpl/contacts/default.php index 997c8442e4e73..a97d837976693 100644 --- a/administrator/components/com_contact/tmpl/contacts/default.php +++ b/administrator/components/com_contact/tmpl/contacts/default.php @@ -61,6 +61,9 @@ + + + @@ -124,12 +127,17 @@ id); ?> + +
+ featured, $i, $canChange); ?> +
+
published, $i, 'contacts.', $canChange, 'cb', $item->publish_up, $item->publish_down); ?> - featured, $i, $canChange); ?> -
+ +
checked_out) : ?> diff --git a/administrator/components/com_content/Model/ArticlesModel.php b/administrator/components/com_content/Model/ArticlesModel.php index 473b4d38ee4cb..9e40977c5fa5f 100644 --- a/administrator/components/com_content/Model/ArticlesModel.php +++ b/administrator/components/com_content/Model/ArticlesModel.php @@ -107,6 +107,9 @@ protected function populateState($ordering = 'a.id', $direction = 'desc') $search = $this->getUserStateFromRequest($this->context . '.filter.search', 'filter_search'); $this->setState('filter.search', $search); + $featured = $this->getUserStateFromRequest($this->context . '.filter.featured', 'filter_featured', ''); + $this->setState('filter.featured', $featured); + $published = $this->getUserStateFromRequest($this->context . '.filter.published', 'filter_published', ''); $this->setState('filter.published', $published); @@ -315,6 +318,14 @@ protected function getListQuery() $query->where('a.access IN (' . $access . ')'); } + // Filter by featured. + $featured = (string) $this->getState('filter.featured'); + + if (in_array($featured, ['0','1'])) + { + $query->where('a.featured =' . (int) $featured); + } + // Filter by access level on categories. if (!$user->authorise('core.admin')) { diff --git a/administrator/components/com_content/forms/filter_articles.xml b/administrator/components/com_content/forms/filter_articles.xml index 63061f4246747..921c9ffa8e786 100644 --- a/administrator/components/com_content/forms/filter_articles.xml +++ b/administrator/components/com_content/forms/filter_articles.xml @@ -9,6 +9,17 @@ hint="JSEARCH_FILTER" /> + + + + + +
+ form->getLabel('articletext'); ?> form->getInput('articletext'); ?>
diff --git a/administrator/components/com_content/tmpl/featured/default.php b/administrator/components/com_content/tmpl/featured/default.php index 90a63fbb2ebe4..2201d2b64515c 100644 --- a/administrator/components/com_content/tmpl/featured/default.php +++ b/administrator/components/com_content/tmpl/featured/default.php @@ -104,6 +104,9 @@ + + + @@ -207,10 +210,12 @@ id); ?> + + render($item->featured, $i, ['disabled' => !$canChange]); ?> +
- render($item->featured, $i, ['disabled' => !$canChange]); ?> 'auto', 'relative' => true)); + $user = Factory::getUser(); ?> @@ -31,7 +38,7 @@
-
+
modules as $module) diff --git a/administrator/components/com_fields/Table/FieldTable.php b/administrator/components/com_fields/Table/FieldTable.php index 5714d3bd1faa4..3a555a9a1b96f 100644 --- a/administrator/components/com_fields/Table/FieldTable.php +++ b/administrator/components/com_fields/Table/FieldTable.php @@ -143,16 +143,14 @@ public function check() } else { + $this->modified_time = $this->getDbo()->getNullDate(); + $this->modified_by = 0; + if (!(int) $this->created_time) { $this->created_time = $date->toSql(); } - if (!(int) $this->modified_time) - { - $this->modified_time = $date->toSql(); - } - if (empty($this->created_user_id)) { $this->created_user_id = $user->get('id'); diff --git a/administrator/components/com_fields/Table/GroupTable.php b/administrator/components/com_fields/Table/GroupTable.php index 0dcf9ec9114f4..7530f575ef8d3 100644 --- a/administrator/components/com_fields/Table/GroupTable.php +++ b/administrator/components/com_fields/Table/GroupTable.php @@ -102,6 +102,9 @@ public function check() } else { + $this->modified = $this->getDbo()->getNullDate(); + $this->modified_by = 0; + if (!(int) $this->created) { $this->created = $date->toSql(); diff --git a/administrator/components/com_installer/Controller/DisplayController.php b/administrator/components/com_installer/Controller/DisplayController.php index 067b63b621333..0acfc8fd5ab88 100644 --- a/administrator/components/com_installer/Controller/DisplayController.php +++ b/administrator/components/com_installer/Controller/DisplayController.php @@ -58,8 +58,6 @@ public function display($cachable = false, $urlparams = false) // Push document object into the view. $view->document = $document; - // Load the submenu. - InstallerHelper::addSubmenu($vName); $view->display(); } diff --git a/administrator/components/com_installer/Helper/InstallerHelper.php b/administrator/components/com_installer/Helper/InstallerHelper.php index 3d287872ae3b3..e14d5305185a0 100644 --- a/administrator/components/com_installer/Helper/InstallerHelper.php +++ b/administrator/components/com_installer/Helper/InstallerHelper.php @@ -22,59 +22,6 @@ */ class InstallerHelper { - /** - * Configure the Linkbar. - * - * @param string $vName The name of the active view. - * - * @return void - * - * @since 1.6 - */ - public static function addSubmenu($vName = 'install') - { - \JHtmlSidebar::addEntry( - Text::_('COM_INSTALLER_SUBMENU_INSTALL'), - 'index.php?option=com_installer', - $vName == 'install' - ); - \JHtmlSidebar::addEntry( - Text::_('COM_INSTALLER_SUBMENU_UPDATE'), - 'index.php?option=com_installer&view=update', - $vName == 'update' - ); - \JHtmlSidebar::addEntry( - Text::_('COM_INSTALLER_SUBMENU_MANAGE'), - 'index.php?option=com_installer&view=manage', - $vName == 'manage' - ); - \JHtmlSidebar::addEntry( - Text::_('COM_INSTALLER_SUBMENU_DISCOVER'), - 'index.php?option=com_installer&view=discover', - $vName == 'discover' - ); - \JHtmlSidebar::addEntry( - Text::_('COM_INSTALLER_SUBMENU_DATABASE'), - 'index.php?option=com_installer&view=database', - $vName == 'database' - ); - \JHtmlSidebar::addEntry( - Text::_('COM_INSTALLER_SUBMENU_WARNINGS'), - 'index.php?option=com_installer&view=warnings', - $vName == 'warnings' - ); - \JHtmlSidebar::addEntry( - Text::_('COM_INSTALLER_SUBMENU_LANGUAGES'), - 'index.php?option=com_installer&view=languages', - $vName == 'languages' - ); - \JHtmlSidebar::addEntry( - Text::_('COM_INSTALLER_SUBMENU_UPDATESITES'), - 'index.php?option=com_installer&view=updatesites', - $vName == 'updatesites' - ); - } - /** * Get a list of filter options for the extension types. * diff --git a/administrator/components/com_installer/View/Discover/HtmlView.php b/administrator/components/com_installer/View/Discover/HtmlView.php index 6aeed8489370d..6171fb6c364ce 100644 --- a/administrator/components/com_installer/View/Discover/HtmlView.php +++ b/administrator/components/com_installer/View/Discover/HtmlView.php @@ -70,8 +70,6 @@ protected function addToolbar() ToolbarHelper::custom('discover.refresh', 'refresh', 'refresh', 'COM_INSTALLER_TOOLBAR_DISCOVER', false); ToolbarHelper::divider(); - \JHtmlSidebar::setAction('index.php?option=com_installer&view=discover'); - parent::addToolbar(); ToolbarHelper::help('JHELP_EXTENSIONS_EXTENSION_MANAGER_DISCOVER'); diff --git a/administrator/components/com_installer/View/Installer/HtmlView.php b/administrator/components/com_installer/View/Installer/HtmlView.php index 9ceb0729d2c2c..e385693dd7adf 100644 --- a/administrator/components/com_installer/View/Installer/HtmlView.php +++ b/administrator/components/com_installer/View/Installer/HtmlView.php @@ -111,8 +111,5 @@ protected function addToolbar() ToolbarHelper::preferences('com_installer'); ToolbarHelper::divider(); } - - // Render side bar. - $this->sidebar = \JHtmlSidebar::render(); } } diff --git a/administrator/components/com_installer/View/Manage/HtmlView.php b/administrator/components/com_installer/View/Manage/HtmlView.php index d7cef4c956a19..c94de5562bfb3 100644 --- a/administrator/components/com_installer/View/Manage/HtmlView.php +++ b/administrator/components/com_installer/View/Manage/HtmlView.php @@ -82,8 +82,6 @@ protected function addToolbar() ToolbarHelper::divider(); } - \JHtmlSidebar::setAction('index.php?option=com_installer&view=manage'); - parent::addToolbar(); ToolbarHelper::help('JHELP_EXTENSIONS_EXTENSION_MANAGER_MANAGE'); } diff --git a/administrator/components/com_installer/View/Update/HtmlView.php b/administrator/components/com_installer/View/Update/HtmlView.php index 9bd669f756e3e..ed85362446d53 100644 --- a/administrator/components/com_installer/View/Update/HtmlView.php +++ b/administrator/components/com_installer/View/Update/HtmlView.php @@ -81,8 +81,6 @@ protected function addToolbar() ToolbarHelper::custom('update.purge', 'purge', 'purge', 'COM_INSTALLER_TOOLBAR_PURGE', false); ToolbarHelper::divider(); - \JHtmlSidebar::setAction('index.php?option=com_installer&view=manage'); - parent::addToolbar(); ToolbarHelper::help('JHELP_EXTENSIONS_EXTENSION_MANAGER_UPDATE'); } diff --git a/administrator/components/com_installer/View/Updatesites/HtmlView.php b/administrator/components/com_installer/View/Updatesites/HtmlView.php index 0af6247b4dc06..dcfe7829136ed 100644 --- a/administrator/components/com_installer/View/Updatesites/HtmlView.php +++ b/administrator/components/com_installer/View/Updatesites/HtmlView.php @@ -88,8 +88,6 @@ protected function addToolbar() ToolbarHelper::custom('updatesites.rebuild', 'refresh.png', 'refresh_f2.png', 'JTOOLBAR_REBUILD', false); } - \JHtmlSidebar::setAction('index.php?option=com_installer&view=updatesites'); - parent::addToolbar(); ToolbarHelper::help('JHELP_EXTENSIONS_EXTENSION_MANAGER_UPDATESITES'); } diff --git a/administrator/components/com_installer/tmpl/database/default.php b/administrator/components/com_installer/tmpl/database/default.php index b9f8e37e2b21f..01c3da3de43c5 100644 --- a/administrator/components/com_installer/tmpl/database/default.php +++ b/administrator/components/com_installer/tmpl/database/default.php @@ -24,10 +24,7 @@
-
- sidebar; ?> -
-
+
$this)); ?> diff --git a/administrator/components/com_installer/tmpl/discover/default.php b/administrator/components/com_installer/tmpl/discover/default.php index 4876f1440651b..3fd27d66b140e 100644 --- a/administrator/components/com_installer/tmpl/discover/default.php +++ b/administrator/components/com_installer/tmpl/discover/default.php @@ -22,10 +22,7 @@
-
- sidebar; ?> -
-
+
showMessage) : ?> loadTemplate('message'); ?> diff --git a/administrator/components/com_installer/tmpl/install/default.php b/administrator/components/com_installer/tmpl/install/default.php index ddf90a9269bfb..03b2962e83acc 100644 --- a/administrator/components/com_installer/tmpl/install/default.php +++ b/administrator/components/com_installer/tmpl/install/default.php @@ -31,10 +31,7 @@
-
- sidebar; ?> -
-
+
showMessage) : ?> diff --git a/administrator/components/com_installer/tmpl/installer/default_ftp.php b/administrator/components/com_installer/tmpl/installer/default_ftp.php index cac3b78400a07..c9e491d3b79f2 100644 --- a/administrator/components/com_installer/tmpl/installer/default_ftp.php +++ b/administrator/components/com_installer/tmpl/installer/default_ftp.php @@ -12,7 +12,7 @@ use Joomla\CMS\Language\Text; ?> -
+
diff --git a/administrator/components/com_installer/tmpl/languages/default.php b/administrator/components/com_installer/tmpl/languages/default.php index 583e364e375ad..ac3ae2ff108ac 100644 --- a/administrator/components/com_installer/tmpl/languages/default.php +++ b/administrator/components/com_installer/tmpl/languages/default.php @@ -22,10 +22,7 @@
-
- sidebar; ?> -
-
+
$this, 'options' => array('filterButton' => false))); ?> items)) : ?> diff --git a/administrator/components/com_installer/tmpl/manage/default.php b/administrator/components/com_installer/tmpl/manage/default.php index 99e384e987da3..b31e99688a9db 100644 --- a/administrator/components/com_installer/tmpl/manage/default.php +++ b/administrator/components/com_installer/tmpl/manage/default.php @@ -22,10 +22,7 @@
-
- sidebar; ?> -
-
+
showMessage) : ?> loadTemplate('message'); ?> diff --git a/administrator/components/com_installer/tmpl/update/default.php b/administrator/components/com_installer/tmpl/update/default.php index 222ea6bd0ab54..80ca2014605d3 100644 --- a/administrator/components/com_installer/tmpl/update/default.php +++ b/administrator/components/com_installer/tmpl/update/default.php @@ -22,10 +22,7 @@
-
- sidebar; ?> -
-
+
showMessage) : ?> loadTemplate('message'); ?> diff --git a/administrator/components/com_installer/tmpl/updatesites/default.php b/administrator/components/com_installer/tmpl/updatesites/default.php index 5d7517ff25dcc..e295ab7304d09 100644 --- a/administrator/components/com_installer/tmpl/updatesites/default.php +++ b/administrator/components/com_installer/tmpl/updatesites/default.php @@ -22,10 +22,7 @@
-
- sidebar; ?> -
-
+
$this)); ?> items)) : ?> diff --git a/administrator/components/com_installer/tmpl/warnings/default.php b/administrator/components/com_installer/tmpl/warnings/default.php index 1b40eff8060fe..2c90198305349 100644 --- a/administrator/components/com_installer/tmpl/warnings/default.php +++ b/administrator/components/com_installer/tmpl/warnings/default.php @@ -17,10 +17,7 @@
-
- sidebar; ?> -
-
+
messages)) : ?> messages as $message) : ?> diff --git a/administrator/components/com_media/layouts/toolbar/create-folder.php b/administrator/components/com_media/layouts/toolbar/create-folder.php index 6cdfe97f46b49..13731d105e7e8 100644 --- a/administrator/components/com_media/layouts/toolbar/create-folder.php +++ b/administrator/components/com_media/layouts/toolbar/create-folder.php @@ -14,5 +14,5 @@ $title = Text::_('COM_MEDIA_CREATE_NEW_FOLDER'); ?> diff --git a/administrator/components/com_media/layouts/toolbar/delete.php b/administrator/components/com_media/layouts/toolbar/delete.php index 6ce601a9ccba9..c22c92ede8d5a 100644 --- a/administrator/components/com_media/layouts/toolbar/delete.php +++ b/administrator/components/com_media/layouts/toolbar/delete.php @@ -14,5 +14,5 @@ $title = Text::_('JTOOLBAR_DELETE'); ?> diff --git a/administrator/components/com_media/layouts/toolbar/upload.php b/administrator/components/com_media/layouts/toolbar/upload.php index 23c4a958bb440..b288b73bbafc4 100644 --- a/administrator/components/com_media/layouts/toolbar/upload.php +++ b/administrator/components/com_media/layouts/toolbar/upload.php @@ -14,5 +14,5 @@ $title = Text::_('JTOOLBAR_UPLOAD'); ?> diff --git a/administrator/components/com_media/resources/scripts/components/modals/confirm-delete-modal.vue b/administrator/components/com_media/resources/scripts/components/modals/confirm-delete-modal.vue index 2cca3b01df078..4843c6965a174 100644 --- a/administrator/components/com_media/resources/scripts/components/modals/confirm-delete-modal.vue +++ b/administrator/components/com_media/resources/scripts/components/modals/confirm-delete-modal.vue @@ -1,39 +1,39 @@ - - - + + + diff --git a/administrator/components/com_media/resources/scripts/components/modals/share-modal.vue b/administrator/components/com_media/resources/scripts/components/modals/share-modal.vue index 17e2a4a559abf..106d698ec47f2 100644 --- a/administrator/components/com_media/resources/scripts/components/modals/share-modal.vue +++ b/administrator/components/com_media/resources/scripts/components/modals/share-modal.vue @@ -15,7 +15,7 @@ - + diff --git a/administrator/components/com_media/tmpl/media/default_texts.php b/administrator/components/com_media/tmpl/media/default_texts.php index ba12c7617ed52..6994c5d87d786 100644 --- a/administrator/components/com_media/tmpl/media/default_texts.php +++ b/administrator/components/com_media/tmpl/media/default_texts.php @@ -17,9 +17,8 @@ Text::script('COM_MEDIA_ACTION_RENAME', true); Text::script('COM_MEDIA_ACTION_SHARE', true); Text::script('COM_MEDIA_BREADCRUMB_LABEL', true); -Text::script('COM_MEDIA_CONFIRM_DELETE_MODEL', true); -Text::script('COM_MEDIA_CONFIRM_DELETE_MODEL_DESC', true); -Text::script('COM_MEDIA_CONFIRM_DELETE_MODEL_HEADING', true); +Text::script('COM_MEDIA_CONFIRM_DELETE_MODAL', true); +Text::script('COM_MEDIA_CONFIRM_DELETE_MODAL_HEADING', true); Text::script('COM_MEDIA_CREATE_NEW_FOLDER', true); Text::script('COM_MEDIA_CREATE_NEW_FOLDER_ERROR', true); Text::script('COM_MEDIA_CREATE_NEW_FOLDER_SUCCESS', true); @@ -53,6 +52,7 @@ Text::script('COM_MEDIA_SELECT_ALL', true); Text::script('COM_MEDIA_SERVER_ERROR', true); Text::script('COM_MEDIA_SHARE', true); +Text::script('COM_MEDIA_SHARE_COPY', true); Text::script('COM_MEDIA_SHARE_COPY_FAILED_ERROR', true); Text::script('COM_MEDIA_SHARE_DESC', true); Text::script('COM_MEDIA_TOGGLE_INFO', true); @@ -63,4 +63,5 @@ Text::script('JACTION_CREATE', true); Text::script('JAPPLY', true); Text::script('JCANCEL', true); +Text::script('JGLOBAL_CONFIRM_DELETE', true); Text::script('JLIB_FORM_FIELD_REQUIRED_VALUE', true); diff --git a/administrator/components/com_menus/Field/MenutypeField.php b/administrator/components/com_menus/Field/MenutypeField.php index 65a4b8524be6c..b80c15151748c 100644 --- a/administrator/components/com_menus/Field/MenutypeField.php +++ b/administrator/components/com_menus/Field/MenutypeField.php @@ -90,8 +90,8 @@ protected function getInput() $link = Route::_('index.php?option=com_menus&view=menutypes&tmpl=component&client_id=' . $clientId . '&recordId=' . $recordId); $html[] = ''; - $html[] = ''; $html[] = HTMLHelper::_( 'bootstrap.renderModal', diff --git a/administrator/components/com_menus/tmpl/menutypes/default.php b/administrator/components/com_menus/tmpl/menutypes/default.php index 24134db0ca682..cfddb2137c585 100644 --- a/administrator/components/com_menus/tmpl/menutypes/default.php +++ b/administrator/components/com_menus/tmpl/menutypes/default.php @@ -30,7 +30,7 @@ $item) : ?> $this->recordId, 'title' => $item->type ?? $item->title, 'request' => $item->request); ?> -
diff --git a/administrator/components/com_modules/Controller/ModuleController.php b/administrator/components/com_modules/Controller/ModuleController.php index 59613fcf13904..c8803931d91b5 100644 --- a/administrator/components/com_modules/Controller/ModuleController.php +++ b/administrator/components/com_modules/Controller/ModuleController.php @@ -81,6 +81,11 @@ public function cancel($key = null) $this->app->setUserState('com_modules.add.module.extension_id', null); $this->app->setUserState('com_modules.add.module.params', null); + if ($return = $this->input->get('return', '', 'BASE64')) + { + $this->app->redirect(base64_decode($return)); + } + return $result; } diff --git a/administrator/components/com_modules/View/Modules/HtmlView.php b/administrator/components/com_modules/View/Modules/HtmlView.php index f3d1de6ebb8c9..d3bc59d3bf892 100644 --- a/administrator/components/com_modules/View/Modules/HtmlView.php +++ b/administrator/components/com_modules/View/Modules/HtmlView.php @@ -163,11 +163,6 @@ protected function addToolbar() { $toolbar->standardButton('new', 'JTOOLBAR_NEW') ->onclick("location.href='index.php?option=com_modules&view=select'"); - - $toolbar->standardButton('copy') - ->text('JTOOLBAR_DUPLICATE') - ->task('modules.duplicate') - ->listCheck(true); } if ($canDo->get('core.edit.state') || Factory::getUser()->authorise('core.admin')) @@ -209,6 +204,14 @@ protected function addToolbar() ->listCheck(true); } + if ($canDo->get('core.create')) + { + $toolbar->standardButton('copy') + ->text('JTOOLBAR_DUPLICATE') + ->task('modules.duplicate') + ->listCheck(true); + } + if ($state->get('filter.state') == -2 && $canDo->get('core.delete')) { $toolbar->delete('modules.delete') diff --git a/administrator/components/com_modules/layouts/toolbar/cancelselect.php b/administrator/components/com_modules/layouts/toolbar/cancelselect.php index 62ca82f28a97e..97fb09546ed44 100644 --- a/administrator/components/com_modules/layouts/toolbar/cancelselect.php +++ b/administrator/components/com_modules/layouts/toolbar/cancelselect.php @@ -13,6 +13,6 @@ $text = Text::_('JTOOLBAR_CANCEL'); ?> - diff --git a/administrator/components/com_modules/tmpl/module/edit.php b/administrator/components/com_modules/tmpl/module/edit.php index 01b4ba70485c4..f5b86dccbc3ef 100644 --- a/administrator/components/com_modules/tmpl/module/edit.php +++ b/administrator/components/com_modules/tmpl/module/edit.php @@ -194,6 +194,7 @@ + form->getInput('module'); ?> form->getInput('client_id'); ?> diff --git a/administrator/components/com_modules/tmpl/modules/default_batch_body.php b/administrator/components/com_modules/tmpl/modules/default_batch_body.php index d683626e4f1ac..62b105e5d2828 100644 --- a/administrator/components/com_modules/tmpl/modules/default_batch_body.php +++ b/administrator/components/com_modules/tmpl/modules/default_batch_body.php @@ -41,24 +41,18 @@
-
-
+
+
-
-
+
+
-
-
+
+
-
-
- - -
-
- +
-
+
diff --git a/administrator/components/com_tags/tmpl/tag/edit.php b/administrator/components/com_tags/tmpl/tag/edit.php index 68b18b468391a..ec5c7e31270a4 100644 --- a/administrator/components/com_tags/tmpl/tag/edit.php +++ b/administrator/components/com_tags/tmpl/tag/edit.php @@ -35,7 +35,8 @@
- form->renderField('description'); ?> + form->getLabel('description'); ?> + form->getInput('description'); ?>
diff --git a/administrator/components/com_templates/View/Styles/HtmlView.php b/administrator/components/com_templates/View/Styles/HtmlView.php index 3e4aa8cef8ac1..b1ce2c1025305 100644 --- a/administrator/components/com_templates/View/Styles/HtmlView.php +++ b/administrator/components/com_templates/View/Styles/HtmlView.php @@ -96,7 +96,6 @@ public function display($tpl = null) } $this->addToolbar(); - $this->sidebar = \JHtmlSidebar::render(); return parent::display($tpl); } @@ -147,7 +146,5 @@ protected function addToolbar() } ToolbarHelper::help('JHELP_EXTENSIONS_TEMPLATE_MANAGER_STYLES'); - - \JHtmlSidebar::setAction('index.php?option=com_templates&view=styles'); } } diff --git a/administrator/components/com_templates/View/Templates/HtmlView.php b/administrator/components/com_templates/View/Templates/HtmlView.php index 8f862be139ce2..25b9ee8fe28ae 100644 --- a/administrator/components/com_templates/View/Templates/HtmlView.php +++ b/administrator/components/com_templates/View/Templates/HtmlView.php @@ -151,9 +151,5 @@ protected function addToolbar() } ToolbarHelper::help('JHELP_EXTENSIONS_TEMPLATE_MANAGER_TEMPLATES'); - - \JHtmlSidebar::setAction('index.php?option=com_templates&view=templates'); - - $this->sidebar = \JHtmlSidebar::render(); } } diff --git a/administrator/components/com_templates/tmpl/styles/default.php b/administrator/components/com_templates/tmpl/styles/default.php index 5cf0824f4935e..1c2416bd358aa 100644 --- a/administrator/components/com_templates/tmpl/styles/default.php +++ b/administrator/components/com_templates/tmpl/styles/default.php @@ -26,10 +26,7 @@ ?>
-
- sidebar; ?> -
-
+
$this, 'options' => array('selectorFieldName' => 'client_id'))); ?> total > 0) : ?> diff --git a/administrator/components/com_templates/tmpl/templates/default.php b/administrator/components/com_templates/tmpl/templates/default.php index e452aaffdf37f..3d213d831f6a0 100644 --- a/administrator/components/com_templates/tmpl/templates/default.php +++ b/administrator/components/com_templates/tmpl/templates/default.php @@ -25,10 +25,7 @@
-
- sidebar; ?> -
-
+
$this, 'options' => array('selectorFieldName' => 'client_id'))); ?> total > 0) : ?> diff --git a/administrator/components/com_users/Controller/UserController.php b/administrator/components/com_users/Controller/UserController.php index 3d79b0fec1781..dce81ba851b0c 100644 --- a/administrator/components/com_users/Controller/UserController.php +++ b/administrator/components/com_users/Controller/UserController.php @@ -57,6 +57,27 @@ protected function allowEdit($data = array(), $key = 'id') return parent::allowEdit($data, $key); } + /** + * Override parent cancel to redirect when using status edit account. + * + * @param string $key The name of the primary key of the URL variable. + * + * @return boolean True if access level checks pass, false otherwise. + * + * @since __DEPLOY_VERSION__ + */ + public function cancel($key = null) + { + $result = parent::cancel(); + + if ($return = $this->input->get('return', '', 'BASE64')) + { + $this->app->redirect(base64_decode($return)); + } + + return $result; + } + /** * Method to run batch operations. * diff --git a/administrator/components/com_users/Service/HTML/Users.php b/administrator/components/com_users/Service/HTML/Users.php index 6cbc455dfad93..0bb86942be642 100644 --- a/administrator/components/com_users/Service/HTML/Users.php +++ b/administrator/components/com_users/Service/HTML/Users.php @@ -63,7 +63,7 @@ public function addNote($userId) $title = Text::_('COM_USERS_ADD_NOTE'); return ''; } diff --git a/administrator/components/com_users/View/Users/HtmlView.php b/administrator/components/com_users/View/Users/HtmlView.php index 0671a12ae1f8b..9f4dba0b07f27 100644 --- a/administrator/components/com_users/View/Users/HtmlView.php +++ b/administrator/components/com_users/View/Users/HtmlView.php @@ -166,14 +166,6 @@ protected function addToolbar() ->listCheck(true); } - if ($canDo->get('core.delete')) - { - $toolbar->delete('users.delete') - ->text('JTOOLBAR_DELETE') - ->message('JGLOBAL_CONFIRM_DELETE') - ->listCheck(true); - } - // Add a batch button if ($user->authorise('core.create', 'com_users') && $user->authorise('core.edit', 'com_users') @@ -185,6 +177,14 @@ protected function addToolbar() ->listCheck(true); } + if ($canDo->get('core.delete')) + { + $toolbar->delete('users.delete') + ->text('JTOOLBAR_DELETE') + ->message('JGLOBAL_CONFIRM_DELETE') + ->listCheck(true); + } + if ($canDo->get('core.admin') || $canDo->get('core.options')) { $toolbar->preferences('com_users'); diff --git a/administrator/components/com_users/tmpl/user/edit.php b/administrator/components/com_users/tmpl/user/edit.php index d57dffa209fbe..93572c8d8f7cb 100644 --- a/administrator/components/com_users/tmpl/user/edit.php +++ b/administrator/components/com_users/tmpl/user/edit.php @@ -9,6 +9,7 @@ defined('_JEXEC') or die; +use Joomla\CMS\Factory; use Joomla\CMS\HTML\HTMLHelper; use Joomla\CMS\Language\Text; use Joomla\CMS\Layout\LayoutHelper; @@ -18,6 +19,8 @@ HTMLHelper::_('behavior.formvalidator'); HTMLHelper::_('script', 'com_users/admin-users-user.min.js', array('version' => 'auto', 'relative' => true)); +$input = Factory::getApplication()->input; + // Get the form fieldsets. $fieldsets = $this->form->getFieldsets(); $settings = array(); @@ -60,8 +63,7 @@
-
@@ -105,5 +107,6 @@
+ diff --git a/administrator/language/en-GB/en-GB.com_admin.ini b/administrator/language/en-GB/en-GB.com_admin.ini index d3eae9c254bec..15c389bbc5af3 100644 --- a/administrator/language/en-GB/en-GB.com_admin.ini +++ b/administrator/language/en-GB/en-GB.com_admin.ini @@ -6,7 +6,6 @@ COM_ADMIN="System Information" COM_ADMIN_ALPHABETICAL_INDEX="Alphabetical Index" COM_ADMIN_CACHE_DIRECTORY="(Cache Folder)" -COM_ADMIN_CLEAR_RESULTS="Clear results" COM_ADMIN_CONFIGURATION_FILE="Configuration File" COM_ADMIN_DATABASE_COLLATION="Database Collation" COM_ADMIN_DATABASE_CONNECTION_COLLATION="Database Connection Collation" @@ -21,7 +20,6 @@ COM_ADMIN_DOWNLOAD_SYSTEM_INFORMATION_JSON="Download as JSON" COM_ADMIN_EXTENSIONS="Extensions" COM_ADMIN_FILE_UPLOADS="File Uploads" COM_ADMIN_GLOSSARY="Glossary" -COM_ADMIN_GO="Go" COM_ADMIN_HELP="Joomla! Help" COM_ADMIN_HELP_COMPONENTS_ASSOCIATIONS="Multilingual Associations" COM_ADMIN_HELP_COMPONENTS_ASSOCIATIONS_EDIT="Multilingual Associations: Select" @@ -107,15 +105,12 @@ COM_ADMIN_HELP_USERS_USER_NOTES_EDIT="Users: User Notes - New/Edit" COM_ADMIN_HELP_USERS_USER_MANAGER="Users" COM_ADMIN_HELP_USERS_USER_MANAGER_EDIT="Users: New/Edit" COM_ADMIN_ICONV_AVAILABLE="Iconv Available" -COM_ADMIN_INFORMATION="System Information" COM_ADMIN_JOOMLA_VERSION="Joomla! Version" COM_ADMIN_LATEST_VERSION_CHECK="Latest Version Check" COM_ADMIN_LICENSE="License" COM_ADMIN_LOG_DIRECTORY="(Log folder)" -COM_ADMIN_MAGIC_QUOTES="Magic Quotes" COM_ADMIN_MAX_INPUT_VARS="Maximum Input Variables" COM_ADMIN_MBSTRING_ENABLED="Multibyte String (mbstring) Enabled" -COM_ADMIN_MCRYPT_ENABLED="Mcrypt Enabled" COM_ADMIN_MEDIA_CACHE_DIRECTORY="Cached Media Directory" COM_ADMIN_NA="n/a" COM_ADMIN_OPEN_BASEDIR="Open basedir" @@ -125,16 +120,12 @@ COM_ADMIN_PHP_INFORMATION="PHP Information" COM_ADMIN_PHP_SETTINGS="PHP Settings" COM_ADMIN_PHP_VERSION="PHP Version" COM_ADMIN_PHPINFO_DISABLED="The built in phpinfo() function has been disabled by your host." -COM_ADMIN_PLATFORM_VERSION="Joomla! Platform Version" -COM_ADMIN_RELEVANT_PHP_SETTINGS="Relevant PHP Settings" -COM_ADMIN_SEARCH="Search" COM_ADMIN_SESSION_AUTO_START="Session Auto Start" COM_ADMIN_SESSION_SAVE_PATH="Session Save Path" COM_ADMIN_SETTING="Setting" COM_ADMIN_SHORT_OPEN_TAGS="Short Open Tags" COM_ADMIN_START_HERE="Start here" COM_ADMIN_STATUS="Status" -COM_ADMIN_SYSTEM_INFO="System Info" COM_ADMIN_SYSTEM_INFORMATION="System Information" COM_ADMIN_TEMP_DIRECTORY="(Temp folder)" COM_ADMIN_UNWRITABLE="Unwritable" @@ -147,4 +138,3 @@ COM_ADMIN_XML_DESCRIPTION="Administration system information component." COM_ADMIN_XML_ENABLED="XML Enabled" COM_ADMIN_ZIP_ENABLED="Native ZIP Enabled" COM_ADMIN_ZLIB_ENABLED="Zlib Enabled" - diff --git a/administrator/language/en-GB/en-GB.com_content.ini b/administrator/language/en-GB/en-GB.com_content.ini index bb9a96288d182..85b6f188568d3 100644 --- a/administrator/language/en-GB/en-GB.com_content.ini +++ b/administrator/language/en-GB/en-GB.com_content.ini @@ -90,6 +90,8 @@ COM_CONTENT_FIELD_VALUE_USE_ARTICLE_SETTINGS="Use Article Settings" COM_CONTENT_FIELD_VERSION_LABEL="Revision" COM_CONTENT_FIELD_XREFERENCE_DESC="An optional reference used to link to external data sources." COM_CONTENT_FIELD_XREFERENCE_LABEL="External Reference" +COM_CONTENT_FILTER_FEATURED_NO="Unfeatured Articles" +COM_CONTENT_FILTER_FEATURED_YES="Featured Articles" COM_CONTENT_FILTER_SEARCH_DESC="Search in title and alias. Prefix with ID: or AUTHOR: to search for an article ID or article author." COM_CONTENT_FILTER_SEARCH_LABEL="Search Articles" COM_CONTENT_FLOAT_FULLTEXT_LABEL="Full Text Image Float" @@ -143,6 +145,7 @@ COM_CONTENT_RUN_TRANSITIONS="Run Transitions" COM_CONTENT_SAVE_SUCCESS="Article saved." COM_CONTENT_SAVE_WARNING="Alias already existed so a number was added at the end. You can re-edit the article to customise the alias." COM_CONTENT_SELECT_AN_ARTICLE="Select an Article" +COM_CONTENT_SELECT_FEATURED="- Select Featured -" COM_CONTENT_SHARED_DESC="These settings apply for Shared Options in List, Blog and Featured unless they are changed by the menu settings." COM_CONTENT_SHARED_LABEL="Shared" COM_CONTENT_SHOW_ARTICLE_OPTIONS_LABEL="Article Options" diff --git a/administrator/language/en-GB/en-GB.com_cpanel.ini b/administrator/language/en-GB/en-GB.com_cpanel.ini index 057fd02fcf1cf..5352801fa9eb8 100644 --- a/administrator/language/en-GB/en-GB.com_cpanel.ini +++ b/administrator/language/en-GB/en-GB.com_cpanel.ini @@ -24,6 +24,8 @@ COM_CPANEL_MSG_UPDATEDEFAULTSETTINGS_BODY="

As part of our security team's rev COM_CPANEL_MSG_UPDATEDEFAULTSETTINGS_TITLE="Updated site security recommendations" COM_CPANEL_SYSTEM_SETUP="Setup" COM_CPANEL_TITLE_SYSTEM_PANEL="System Panel" +COM_CPANEL_UNPUBLISH_MODULE_ERROR="Error unpublishing the module" +COM_CPANEL_UNPUBLISH_MODULE_SUCCESS="Module unpublished" COM_CPANEL_WELCOME_BEGINNERS_MESSAGE="

Community resources are available for new users.

" COM_CPANEL_WELCOME_BEGINNERS_TITLE="Welcome to Joomla!" COM_CPANEL_XML_DESCRIPTION="Control Panel component" diff --git a/administrator/language/en-GB/en-GB.com_installer.ini b/administrator/language/en-GB/en-GB.com_installer.ini index 1b9e9e191d49d..985575ca48742 100644 --- a/administrator/language/en-GB/en-GB.com_installer.ini +++ b/administrator/language/en-GB/en-GB.com_installer.ini @@ -203,13 +203,6 @@ COM_INSTALLER_PACKAGE_FILE="Package File" COM_INSTALLER_PREFERENCES_DESCRIPTION="Fine tune how extensions installation and updates work." COM_INSTALLER_PREFERENCES_LABEL="Preferences" COM_INSTALLER_REINSTALL_BUTTON="Reinstall" -COM_INSTALLER_SUBMENU_DATABASE="Database" -COM_INSTALLER_SUBMENU_DISCOVER="Discover" -COM_INSTALLER_SUBMENU_INSTALL="Install" -COM_INSTALLER_SUBMENU_LANGUAGES="Install Languages" -COM_INSTALLER_SUBMENU_MANAGE="Manage" -COM_INSTALLER_SUBMENU_UPDATE="Update" -COM_INSTALLER_SUBMENU_UPDATESITES="Update Sites" COM_INSTALLER_SUBMENU_WARNINGS="Warnings" COM_INSTALLER_TITLE_DATABASE="Extensions: Database" COM_INSTALLER_TITLE_DISCOVER="Extensions: Discover" diff --git a/administrator/language/en-GB/en-GB.com_media.ini b/administrator/language/en-GB/en-GB.com_media.ini index 0eab00a6328b2..425abc83cf6b8 100644 --- a/administrator/language/en-GB/en-GB.com_media.ini +++ b/administrator/language/en-GB/en-GB.com_media.ini @@ -12,9 +12,8 @@ COM_MEDIA_ACTION_RENAME="Rename item" COM_MEDIA_ACTION_SHARE="Get a sharable link" COM_MEDIA_BREADCRUMB_LABEL="Breadcrumb" COM_MEDIA_CONFIGURATION="Media: Options" -COM_MEDIA_CONFIRM_DELETE_MODEL="Delete" -COM_MEDIA_CONFIRM_DELETE_MODEL_DESC="Are you sure you want to delete this item?" -COM_MEDIA_CONFIRM_DELETE_MODEL_HEADING="Confirm Delete" +COM_MEDIA_CONFIRM_DELETE_MODAL="Delete" +COM_MEDIA_CONFIRM_DELETE_MODAL_HEADING="Confirm Delete" COM_MEDIA_CREATE_NEW_FOLDER="Create New Folder" COM_MEDIA_CREATE_NEW_FOLDER_ERROR="Error creating folder." COM_MEDIA_CREATE_NEW_FOLDER_SUCCESS="Folder created." @@ -74,6 +73,7 @@ COM_MEDIA_SEARCH="Search..." COM_MEDIA_SELECT_ALL="Toggle select all" COM_MEDIA_SERVER_ERROR="Internal server error" COM_MEDIA_SHARE="Share the file" +COM_MEDIA_SHARE_COPY="Copy to clipboard" COM_MEDIA_SHARE_COPY_FAILED_ERROR="Error copying to clipboard" COM_MEDIA_SHARE_DESC="Share the file with others. Anyone with link can view the file" COM_MEDIA_TOGGLE_INFO="Toggle item info" diff --git a/administrator/language/en-GB/en-GB.ini b/administrator/language/en-GB/en-GB.ini index ce95576f311bf..27e82cc1e0a27 100644 --- a/administrator/language/en-GB/en-GB.ini +++ b/administrator/language/en-GB/en-GB.ini @@ -152,6 +152,7 @@ JACTION_LOGIN_OFFLINE="Offline Access" JACTION_LOGIN_SITE="Site Login" JACTION_MANAGE="Access Administration Interface" JACTION_OPTIONS="Configure Options Only" +JACTION_UNPUBLISH="Unpublish" JBROWSERTARGET_MODAL="Modal" JBROWSERTARGET_NEW="Open in new window" @@ -170,7 +171,6 @@ JERROR_LAYOUT_PREVIOUS_ERROR="Previous Error" JERROR_LOADFILE_FAILED="Error loading form file" JERROR_LOADING_MENUS="Error loading Menus: %s" JERROR_LOGIN_DENIED="You do not have access to the Administrator section of this site." -JERROR_MAGIC_QUOTES="Your host needs to disable magic_quotes_gpc to run this version of Joomla!" JERROR_NO_ITEMS_SELECTED="No item(s) selected." JERROR_NOLOGIN_BLOCKED="Login denied! Your account has either been blocked or you have not activated it yet." JERROR_SENDING_EMAIL="Email could not be sent." @@ -262,7 +262,6 @@ JFIELD_VERSION_HISTORY_LABEL="Prior Versions" JFIELD_VERSION_HISTORY_SELECT="View Prior Versions" JFIELD_XREFERENCE_DESC="An optional field to allow this record to be cross-referenced to an external data system if required." JFIELD_XREFERENCE_LABEL="External Reference" -JGLOBAL_ACROSS="Across" JGLOBAL_ACTION_PERMISSIONS_LABEL="Permissions" JGLOBAL_ADD_CUSTOM_CATEGORY="Add new Category" JGLOBAL_ALL_ARTICLE="Max Levels Articles" @@ -294,9 +293,6 @@ JGLOBAL_AUTH_FAILED="Failed to authenticate: %s" JGLOBAL_AUTH_INCORRECT="Incorrect username/password" JGLOBAL_AUTH_INVALID_PASS="Username and password do not match or you do not have an account yet." JGLOBAL_AUTH_INVALID_SECRETKEY="The two factor authentication Secret Key is invalid." -; The following 2 strings are deprecated and will be removed with 4.0. -JGLOBAL_AUTH_NO_BIND="Unable to bind to LDAP" -JGLOBAL_AUTH_NO_CONNECT="Unable to connect to LDAP server" JGLOBAL_AUTH_NO_REDIRECT="Could not redirect to server: %s" JGLOBAL_AUTH_NO_USER="Username and password do not match or you do not have an account yet." JGLOBAL_AUTH_NOT_CONNECT="Unable to connect to authentication service." @@ -345,7 +341,6 @@ JGLOBAL_DESCRIPTION="Description" JGLOBAL_DISPLAY_NUM="Display #" JGLOBAL_DISPLAY_SELECT_DESC="Show or hide the Display Select dropdown listbox." JGLOBAL_DISPLAY_SELECT_LABEL="Display Select" -JGLOBAL_DOWN="Down" JGLOBAL_EDIT_ITEM="Edit item" JGLOBAL_EDIT_PREFERENCES="Edit Preferences" JGLOBAL_EMAIL="Email" @@ -468,8 +463,6 @@ JGLOBAL_MODIFIED="Modified" JGLOBAL_MODIFIED_DATE="Modified Date" JGLOBAL_MOST_HITS="Most Hits" JGLOBAL_MOST_RECENT_FIRST="Most Recent First" -JGLOBAL_MULTI_COLUMN_ORDER_DESC="Order articles down or across columns." -JGLOBAL_MULTI_COLUMN_ORDER_LABEL="Multi Column Order" JGLOBAL_MULTI_LEVEL="Multi Level" JGLOBAL_NEWITEMSFIRST_DESC="New items default to the first position. The ordering can be changed after this item is saved." JGLOBAL_NEWITEMSLAST_DESC="New items default to the last position. The ordering can be changed after this item is saved." @@ -478,8 +471,6 @@ JGLOBAL_NO_ORDER="No Order" JGLOBAL_NOINDEX_FOLLOW="No index, follow" JGLOBAL_NOINDEX_NOFOLLOW="No index, no follow" JGLOBAL_NONAPPLICABLE="N/A" -JGLOBAL_NUM_COLUMNS_DESC="The number of columns in which to show Intro Articles. Normally 1, 2, or 3." -JGLOBAL_NUM_COLUMNS_LABEL="# Columns" JGLOBAL_NUM_INTRO_ARTICLES_DESC="Number of articles to show after the leading article. Articles will be shown in columns." JGLOBAL_NUM_INTRO_ARTICLES_LABEL="# Intro Articles" JGLOBAL_NUM_LEADING_ARTICLES_DESC="Number of leading articles to display as full-width at the beginning of the page." diff --git a/administrator/language/en-GB/en-GB.plg_user_profile.ini b/administrator/language/en-GB/en-GB.plg_user_profile.ini index aede58783926c..9fd6f73d91a02 100644 --- a/administrator/language/en-GB/en-GB.plg_user_profile.ini +++ b/administrator/language/en-GB/en-GB.plg_user_profile.ini @@ -29,5 +29,5 @@ PLG_USER_PROFILE_FILL_FIELD_DESC_SITE="If required, please fill this field." PLG_USER_PROFILE_OPTION_AGREE="Agree" PLG_USER_PROFILE_SLIDER_LABEL="User Profile" ; Adapt the following string to the format you entered in the 'DATE_FORMAT_CALENDAR_DATE' -PLG_USER_PROFILE_SPACER_DOB="The date of birth entered should use the format Year-Month-Day, ie 0000-00-00" +PLG_USER_PROFILE_SPACER_DOB="The date of birth entered should use the format Year-Month-Day, eg 2019-01-27." PLG_USER_PROFILE_XML_DESCRIPTION="User Profile Plugin" diff --git a/administrator/modules/mod_stats_admin/tmpl/default.php b/administrator/modules/mod_stats_admin/tmpl/default.php index 6e362b9f3e261..635a3b8a3446b 100644 --- a/administrator/modules/mod_stats_admin/tmpl/default.php +++ b/administrator/modules/mod_stats_admin/tmpl/default.php @@ -11,6 +11,6 @@ ?>
    -
  • title; ?> data; ?>
  • +
  • title; ?> data; ?>
diff --git a/administrator/modules/mod_status/tmpl/default.php b/administrator/modules/mod_status/tmpl/default.php index 857fa2965bd47..5e8ec869adeef 100644 --- a/administrator/modules/mod_status/tmpl/default.php +++ b/administrator/modules/mod_status/tmpl/default.php @@ -65,7 +65,7 @@ -