From e4be7fab0407991d9a0f1a8e0eccaa4f718dedee Mon Sep 17 00:00:00 2001 From: jsboige Date: Sat, 16 May 2026 13:46:56 +0200 Subject: [PATCH] =?UTF-8?q?fix(config):=20remove=20hardcoded=20Debug=20pat?= =?UTF-8?q?hs=20=E2=80=94=20thumbnails=20+=20Freeplane/FreeMind?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - ThumbnailsPathExpression: replace `../../bin/Debug/netcoreapp3.1/Target/...` with `Target/...` (works in both Debug and Release builds) - FreeplanePath/FreeMindPath: change from machine-specific paths (C:\Users\MYIA\...) to empty defaults (configurable via JSON, graceful skip when not found) Fixes #283 (HIGH items 1-5). Build: 0 error, tests: 120 pass / 0 fail. Co-Authored-By: Claude Opus 4.7 --- .../Argumentum.AssetConverter/AssetConverterConfig.cs | 4 ++-- .../Mindmapper/FallacyMindMapDocumentConfig.cs | 5 ++--- .../Mindmapper/MindMapDocumentConfig.cs | 3 +-- .../Mindmapper/VirtueMindMapDocumentConfig.cs | 2 +- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Generation/Converters/Argumentum.AssetConverter/AssetConverterConfig.cs b/Generation/Converters/Argumentum.AssetConverter/AssetConverterConfig.cs index 77b53e97f..e2f647ec3 100644 --- a/Generation/Converters/Argumentum.AssetConverter/AssetConverterConfig.cs +++ b/Generation/Converters/Argumentum.AssetConverter/AssetConverterConfig.cs @@ -241,8 +241,8 @@ public class AssetConverterConfig public FallacyMindMapCreatorConfig FallacyMindMapCreatorConfig { get; set; } = new FallacyMindMapCreatorConfig(); public VirtueMindMapCreatorConfig VirtueMindMapCreatorConfig { get; set; } = new VirtueMindMapCreatorConfig(); - public string FreeplanePath { get; set; } = @"C:\Users\MYIA\AppData\Local\Programs\Freeplane\freeplane.exe"; - public string FreeMindPath { get; set; } = @"C:\Program Files (x86)\FreeMind\FreeMind.exe"; + public string FreeplanePath { get; set; } = ""; + public string FreeMindPath { get; set; } = ""; public Dnn2sxcConfig Dnn2sxcConfig { get; set; } = new Dnn2sxcConfig(); diff --git a/Generation/Converters/Argumentum.AssetConverter/Mindmapper/FallacyMindMapDocumentConfig.cs b/Generation/Converters/Argumentum.AssetConverter/Mindmapper/FallacyMindMapDocumentConfig.cs index 25420ede8..3ce352788 100644 --- a/Generation/Converters/Argumentum.AssetConverter/Mindmapper/FallacyMindMapDocumentConfig.cs +++ b/Generation/Converters/Argumentum.AssetConverter/Mindmapper/FallacyMindMapDocumentConfig.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections; using System.Collections.Generic; using System.Globalization; @@ -183,8 +183,7 @@ public Func LinkFunc - //public string ImagePathExpression { get; set; } = @"../../bin/Debug/netcoreapp3.1/Target/Images/density-0/Fallacies-Web-Thumbnails/{fallacy.FileName}.png"; - public string ThumbnailsPathExpression { get; set; } = @"../../bin/Debug/netcoreapp3.1/Target/Images/density-0/Fallacies-Web-Thumbnails/argumentum_{item.Path}_{item.Text.ToLower().Replace("" "",""_"")}.png"; + public string ThumbnailsPathExpression { get; set; } = @"Target/Images/density-0/Fallacies-Web-Thumbnails/argumentum_{item.Path}_{item.Text.ToLower().Replace("" "",""_"")}.png"; public string GetThumbnailsPath(IMindMapItem item) diff --git a/Generation/Converters/Argumentum.AssetConverter/Mindmapper/MindMapDocumentConfig.cs b/Generation/Converters/Argumentum.AssetConverter/Mindmapper/MindMapDocumentConfig.cs index 48b1537f0..e9bac851b 100644 --- a/Generation/Converters/Argumentum.AssetConverter/Mindmapper/MindMapDocumentConfig.cs +++ b/Generation/Converters/Argumentum.AssetConverter/Mindmapper/MindMapDocumentConfig.cs @@ -168,8 +168,7 @@ public Func LinkFunc - //public string ImagePathExpression { get; set; } = @"../../bin/Debug/netcoreapp3.1/Target/Images/density-0/Fallacies-Web-Thumbnails/{fallacy.FileName}.png"; - public string ThumbnailsPathExpression { get; set; } = @"../../bin/Debug/netcoreapp3.1/Target/Images/density-0/Fallacies-Web-Thumbnails/argumentum_{fallacy.Path}_{fallacy.TextFr.ToLower().Replace("" "",""_"")}.png"; + public string ThumbnailsPathExpression { get; set; } = @"Target/Images/density-0/Fallacies-Web-Thumbnails/argumentum_{fallacy.Path}_{fallacy.TextFr.ToLower().Replace("" "",""_"")}.png"; public string GetThumbnailsPath(Fallacy fallacy) diff --git a/Generation/Converters/Argumentum.AssetConverter/Mindmapper/VirtueMindMapDocumentConfig.cs b/Generation/Converters/Argumentum.AssetConverter/Mindmapper/VirtueMindMapDocumentConfig.cs index 87ef52878..b3fd645fe 100644 --- a/Generation/Converters/Argumentum.AssetConverter/Mindmapper/VirtueMindMapDocumentConfig.cs +++ b/Generation/Converters/Argumentum.AssetConverter/Mindmapper/VirtueMindMapDocumentConfig.cs @@ -173,7 +173,7 @@ public Func LinkFunc } } - public string ThumbnailsPathExpression { get; set; } = @"../../bin/Debug/netcoreapp3.1/Target/Images/density-0/Fallacies-Web-Thumbnails/argumentum_{item.Path}_{item.Text.ToLower().Replace("" "",""_"")}.png"; + public string ThumbnailsPathExpression { get; set; } = @"Target/Images/density-0/Fallacies-Web-Thumbnails/argumentum_{item.Path}_{item.Text.ToLower().Replace("" "",""_"")}.png"; public string GetThumbnailsPath(IMindMapItem item)