Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toornament sometimes returns HTTP Status 429 #7

Open
skamoen opened this issue May 21, 2017 · 1 comment
Open

Toornament sometimes returns HTTP Status 429 #7

skamoen opened this issue May 21, 2017 · 1 comment

Comments

@skamoen
Copy link
Member

skamoen commented May 21, 2017

When using the client in a for-loop, Toornament will eventually start saying NO and return a HTTP Status 429: Too many requests. This should be dealt with in a single method, so the logic for firing the request and extracting the response should be extracted from all the separate methods.

We can then check for a 200 code, or deal with errors in a better way.

Documentation on errors can be found here: https://developer.toornament.com/overview/response-codes

@BrentonPoke
Copy link
Contributor

BrentonPoke commented May 22, 2017

I'm wondering if that's why I can sometime get results and sometimes can't. For some reason, I can never get the list of disciplines anymore, and can't get tournaments by id. I actually can't get anything by id. I only use the for-loop after the request has been made and a List object returned. So it's beyond me why nothing turns up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants