Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor profile edit form #632

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Refactor profile edit form #632

merged 3 commits into from
Mar 27, 2018

Conversation

elarb
Copy link
Member

@elarb elarb commented Mar 27, 2018 •
edited
Loading

  • Use ES6 syntax
  • Improve styling

Closes #582

@skamoen
Copy link
Member

skamoen commented Mar 27, 2018

There's no real reason why we need to know the Gender, so let's remove the field entirely. This needs a change in the API as well, so send "Other" by default until we fix that.

@elarb
Copy link
Member Author

elarb commented Mar 27, 2018

@skamoen I think its better to do that in another PR and immediately change it in the API as well

martijnjanssen
martijnjanssen reviewed Mar 27, 2018
View reviewed changes
src/lancie-my-area/lancie-profile-edit.html
/*
Workaround for a bug that causes paper-input
with type="date" not being editable when empty
(PolymerElements/paper-input/issues/352).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is no longer needed when updating paper-input to 2.2.0 according to this.

Copy link
Member Author

@elarb elarb Mar 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated to 2.2.0 before the issue this fix is for appeared (#585)

@skamoen
Copy link
Member

skamoen commented Mar 27, 2018

Agreed on the gender removal in a separate PR.

Travis is unhappy with a very lengthy error log. Can you look into this?

@martijnjanssen
Copy link
Contributor

martijnjanssen commented Mar 27, 2018 •
edited
Loading

Looks good, in my commit I fixed:

  • The next button when no profile changes are made in the ticket page
  • Close the profile edit form when the user clicks on the check in my-area when no changes are made

martijnjanssen
martijnjanssen approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@martijnjanssen martijnjanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnjanssen martijnjanssen merged commit 56d87de into master Mar 27, 2018
@martijnjanssen martijnjanssen deleted the refactor_profile_edit branch March 27, 2018 21:04
This was referenced Mar 30, 2018
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnjanssen martijnjanssen martijnjanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elarb @skamoen @martijnjanssen