Load FAQ from API #506
Load FAQ from API #506
Conversation
src/lancie-faq/lancie-faq.html
Outdated
| <div class="markdown-html"></div> | ||
| </marked-element> | ||
| <template is="dom-repeat" items="[[faq]]" as="faqitem"> | ||
| <h3>[[faqitem.question]]</h3> |
There was a problem hiding this comment.
Are we certain both h1 and h2 are used before this? Dont use h3 just for styling. Use the proper heading and then style with css.
There was a problem hiding this comment.
the markdown document uses ### Question which according the markdown spec directly translates to a <h3> element.
<h1> and <h2> are definitely not used before this
MatthijsKok
force-pushed
the
feature-dynamic_faq
branch
from
c6fcd73
to
105900a
Compare
MatthijsKok
force-pushed
the
feature-dynamic_faq
branch
from
b8f5bba
to
852abd9
Compare
|
All done, only needs adminpanel implementation. |
|
@MatthijsKok and @martijnjanssen can you have a look at this pull request and what should be done before it can be merged? |
|
I think it's a matter of checking whether the API does what is required from an implementation standpoint here. If that is fulfilled, and testing it works, then it should be fine. I don't have that much knowledge about these old PR's anymore though. |
No description provided.