Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up lancie-register and lancie-consumption #489

Open
TimvdLippe opened this issue Jun 4, 2017 · 4 comments
Open

Clean up lancie-register and lancie-consumption #489

TimvdLippe opened this issue Jun 4, 2017 · 4 comments
Labels
enhancement help wanted priority:high

Comments

@TimvdLippe
Copy link
Member

It appears that these elements are fairly duplicate, contain a lot of ugly code and probably have a number of bugs too. We should clean these up, probably have less elements in there and make sure they work in a nice way
@TimvdLippe
Copy link
Member Author

We can also add lancie-seatmap to this list

@TimvdLippe
Copy link
Member Author

lancie-register-confirm has random booleans with magic values

@TimvdLippe
Copy link
Member Author

lancie-order-check has the same magic boolean values as lancie-register-confirm. Did we copy past 😥 ?

@dsluijk dsluijk closed this as completed Nov 25, 2020
@Fastjur
Copy link
Member

Fastjur commented Nov 26, 2020

Did the methods get cleaned up, if not, why close this issue?

@Fastjur Fastjur reopened this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted priority:high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fastjur @TimvdLippe @dsluijk