Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome autofill doesn't work on login form #318

Open
MatthijsKok opened this issue Nov 28, 2016 · 9 comments
Open

Chrome autofill doesn't work on login form #318

MatthijsKok opened this issue Nov 28, 2016 · 9 comments
Assignees

Comments

@MatthijsKok
Copy link
Contributor

Steps to reproduce:

  • have an email address saved in chrome autofill as A5L username
  • go to: https://areafiftylan.nl/my-area
  • type part of your username
  • click on the popup with the full username
  • observe the username hasn't been filled out.
@martijnjanssen
Copy link
Contributor

Could you find out what makes a form compliant to the chrome autofill options? I believe this is a matter of changing the field names.

@MatthijsKok MatthijsKok self-assigned this Jan 3, 2017
@martijnjanssen
Copy link
Contributor

I think the chrome auto-fill does not work because there are no <form> tags around the inputs. I'll have to check though.

@MatthijsKok
Copy link
Contributor Author

I fixed this, just never pushed.

around it fixes the issue.
However, the "Save password?" popup never happens since we do not post the form, or redirect to a different case. So only the username will be autofill, not the password.

@martijnjanssen
Copy link
Contributor

I have a fix in mind for this that is fairly easy and will remove the checking complexity from the element. It should be fixable with an <iron-form>.

@TimvdLippe
Copy link
Member

iron-form PR was merged, but it does not appear to work still

@martijnjanssen
Copy link
Contributor

I think this is a more promising way of fixing the problem.

@martijnjanssen
Copy link
Contributor

Okay, @TimvdLippe and I have found the problem. It does actually work,
But since there are multiple login forms in the page, only the first one has autofill. In our case, the first one is the one in my-area. This one does indeed have autofill.

@martijnjanssen
Copy link
Contributor

The lastpass password manager now works on the website, I'm not sure about the other methods.

@skamoen
Copy link
Member

skamoen commented Feb 15, 2018

Keepass works too. Good enough to close this, unless we hear about about another big one not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants