Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve required password strength #501

Open
elarb opened this issue Oct 9, 2018 · 4 comments
Open

Improve required password strength #501

elarb opened this issue Oct 9, 2018 · 4 comments
Labels

Comments

@elarb
Copy link
Member

elarb commented Oct 9, 2018

Currently, the password strength control is very poor (e.g. passwords with a single character are allowed). We should improve the required password strength to protect the users from being compromised (either manually or by automated means).

OWASP has a great guideline that we could follow.

@elarb elarb added the security label Oct 9, 2018
@TimvdLippe
Copy link
Member

I think a minimum length is good. A maximum length of 128 is necessary to ensure proper data persistence. I think we should not implement any other requirement and leave that to the user.

@svenpopping
Copy link

Maybe you can use the HaveIBeenPwnd.com API to show people that their password has been in a data breach. But I'm not sure if that is possible...

@elarb
Copy link
Member Author

elarb commented Oct 9, 2018

@svenpopping Yea sounds cool and its probably possible, but I think it's kind of out of scope and I don't think that we should depend on an external API for the password

@dsluijk
Copy link
Member

dsluijk commented Nov 25, 2020

Could use Dropbox's password checker: https://github.com/dropbox/zxcvbn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants