-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make collection detail page more better #3956
Comments
@dustymc I will work on this - I have some stuff started and once you pull, I'll see how it looks. |
You gotta commit first.... |
Sorry - doing three things at once! |
Other things that would be cool here:
|
That deserves a dedicated discussion. Eg https://doi.org/10.1016/j.tree.2021.07.009 just downloaded everything in GBIF (https://doi.org/10.15468/dl.3pa1nh), there's no way to know if they actually used anything from https://www.gbif.org/resource/search?contentType=literature&gbifDatasetKey=5a6977c1-ece6-44b8-b71d-43cb1d4e0919 or not. Depending on the circumstances that may all make perfect sense, or be a step backwards from "some rats from Alaska." This has come up a few times, I don't think anyone quite knows what to make of it, at the very least it should be clearly contrasted with what Arctos calls "citations." |
Agree - and some sort of statement to that effect along with the widget makes sense. |
Sent to GRSciColl today:
Teresa J. Mayfield-Meyer |
Response from GRSciColl:
|
|
It doesn't work - boo hoo! |
trying something else |
Well, now there is a link, but the page 404s - need to get agent ID |
See if this works! |
It worked! Yay! |
I think that's all I can do here. taxonomy can include comma separated terms and maps can wait. |
Nice work @Jegelewicz! One other comment about the display here: for the collections that have their acronym after their institutions name, it displays twice on the collections page: |
@Jegelewicz those agent links are expensive - which probably doesn't matter from that page which gets very low traffic, but in general pulling the ID and building
No, somewhere we agreed to take whatever's supplied (and it's now editable in the UI, so any standardizations wouldn't last). I can help clean up any weirdness from previous attempts (or whatever that is) though.
"includes" is almost guaranteed to find a way to melt something, "ends with space-paren-string-paren" is probably workable. I'd still rather just figure out why we've done that and un-do it if it's not doing anything useful/is causing problems. Better yet, can we just standardize the collection header and its usage? I think there's some leftover portal-idea and it's possible to display CollectionA's header over CollectionB's data (eg in specimenresults) so we can't just always display the simple license-n-such-having version. Can we limit header customization to catalog records and simplify, or simplify/standardize in some other way? |
@acdoll Go to manage collection and remove the thing in parenthesis There is further discussion of this here - https://github.com/ArctosDB/internal/issues/161#issuecomment-1032929539 |
I copied the code from Project pages - which probably gets used quite a bit more and maybe should be less expensive too? |
Thx-changed for next release. |
This is why I hesitated even mentioning this minor issue.
Thanks. I knew that, but I can only change our collections - I was looking for a more comprehensive solution for all collections.
This seems like a reasonable suggestion. |
I'm beginning to feel like that page needs some love and also that you should be able to get to it from any record in the collection rather than it being kinda hidden the way it is now.
Originally posted by @Jegelewicz in #3953 (comment)
The text was updated successfully, but these errors were encountered: