Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of "Launcher hidden" entries for Apps with Icon Pack support #1873

Closed
TotallyAvailable opened this issue Dec 24, 2023 · 3 comments
Closed

Comments

@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Dec 24, 2023

As I seem to remember a discussion/removal of Icons linked to WebApps (unless I picked that up somewhere else...) I thought about actually asking before I start something big that won't make it.

What are your thoughts on including entries that won't show up in a Launcher but get picked up by Apps with Icon Pack support ?

@TotallyAvailable TotallyAvailable changed the title Including Entries for Apps with Icon Pack support Inclusion of "Launcher hidden" entries for Apps with Icon Pack support Dec 24, 2023
@Donnnno
Copy link
Collaborator

Donnnno commented Dec 24, 2023

Can you give an example of an app like that?

Web apps are allowed if someone makes it, but they're disabled in the request function because of their unique IDs

@TotallyAvailable
Copy link
Contributor Author

TotallyAvailable commented Dec 24, 2023

Well given that I ignored the reason most of them don't show up in a launcher...I didn't quite think through the 'how to bind' them with at least the default Android Icon.
Might've been a smart idea to actually look at how Apps like Hail deal with those before asking. I assume there shouldn't be anything stopping it from just loading the drawables based on the Packagename alone.

As for why even bother -> consistency and small surprises for current and future users.
Fewer reasons for more Apps to not adopt support for Icon Packs if System Apps actually get covered as well.
Also no issues with broken entries in the future...

The consequences of it actually working would obviously be quite a bit of crowd sourcing to cover OEM specific stuff.

I might just be dreaming too much though.

Edit:
In theory it shouldn't be too hard to include a case for Apps without (main) activities by telling it to search for something like
<item component="ComponentInfo{com.android.theme.font.googlesans/custom.icon}" drawable="android"/>
with 'custom.icon' as hardcoded value to keep the structure consistent.

Package without activities -> search for 'packagename/custom.icon' instead

While it could probably be done without 'custom.icon' by simply linking 0 activities to the default Android icon, plenty of system and user apps actually come with custom/different icons and/or activities. (like de.dlyt.yanndroid.notinotes)

Maybe @kaanelloed knows if that's something current/standard implementations would allow by adding a few more lines of code or if there's something else I'm not thinking about.

@kaanelloed
Copy link
Contributor

I've never really looked at web apps icons, but from what I understand, I don't think any launcher has implemented a way to apply icon packs with web apps.

@TotallyAvailable TotallyAvailable closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants