Bug: Heretic logic for E5M4 Silver Shield 2 (Kakis region) is NOT green OR yellow, but just yellow.

[PointMeAtTheDawn]

What happened?

I'm not familiar enough with the rules to be able to propose the proper fix across regions, but the northwest area with the silver shield 2 has no relevance to the green key. Because of https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/heretic/Rules.py#L626 (or L633?) being ORs, this generated a softlock for our multiworld.

Thanks!

What were the expected results?

The SS2 and surrounding items require the yellow key, green is insufficient.

Software

Website

[ScipioWright]

@KScl

[KScl]

Logic appears to be written as if the Wings of Wrath in the opening room is reachable by the player, but in reality it is too high up to reach until after obtaining both Yellow and Green keys.

There are a few logic issues (this being one of them) across the id Tech 1 games that I plan to fix in a later PR.