Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: limit slot name when generating, and give appropriate error (Currently ' ' generates) #4629

Open
jacobmix opened this issue Feb 9, 2025 · 1 comment
Labels
waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.

Comments

@jacobmix
Copy link

jacobmix commented Feb 9, 2025

What happened?

Currently you can generate with player yamls containing: name: ' '
Probably not a good thing. Maybe throw an error if Slot/Player Name doesn't pass a check or something.
Discord convo.

What were the expected results?

name: ' ' would throw an error saying yaml player name is not allowed/needs to change.

Software

Local generation

@jacobmix
Copy link
Author

jacobmix commented Feb 9, 2025

It seems there's not many restrictions when making slot names.
Archipelago just deletes trailing/leading spaces, and removes any character after 16.
new_name.strip()[:16].strip()
Would probably be good to change rules such you need: at least one non-whitepace character, and not allow:[, ], {, }, ".

Note: if your name uses ' enclose the name with ". Example: name: "Player's Name".

Also maybe give a warning if player name change? Currently if you use more than 16 characters Archipelago just cuts it off.
Granted it's only an issue for the one not following the 16 limit as stated in the yaml. But will error if similar names break 16.

@ScipioWright ScipioWright added the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

No branches or pull requests

2 participants