Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

big game makes sphere tracker not very usable #4603

Open
beauxq opened this issue Feb 3, 2025 · 2 comments
Open

big game makes sphere tracker not very usable #4603

beauxq opened this issue Feb 3, 2025 · 2 comments
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features.

Comments

@beauxq
Copy link
Collaborator

beauxq commented Feb 3, 2025

I opened the sphere_tracker page from the webhost with a not-really-that-big async (28000 locations) -
Lots of "web page not responding" trying to use it.

I tried putting a drawCallback ( https://datatables.net/reference/option/drawCallback ) in the configuration of the DataTable in trackerCommon.js to hide the table when the (filtered) number of rows is big, but that didn't really help much. A lot of the processing is in the filtering on every keyup event.

I'm not sure of the best way to handle it.
I don't know if there's a good way to do the filtering on the server or client depending on the number of locations.

Software

Website

@black-sliver
Copy link
Member

black-sliver commented Feb 4, 2025

Datatables dies at ~5000 rows, primarily because of the styles it applies. The solution is pagination, either client side (single json) or server side should work for the amount of rows we normally have.

Not really an expert, so I'd prefer someone else to implement it.

Edit: i believe there were two modes even when operating on DOM, but I didn't have success improving performance in another project and switched to json.

@ShinyNT
Copy link
Contributor

ShinyNT commented Feb 5, 2025

I still think sphere tracker showing only progression by default would make it much more usable for big multiworlds (conveniently because it won't need to load literally every item, which is ultimately what causes the page to die)

@ScipioWright ScipioWright added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

No branches or pull requests

4 participants