Skip to content

test: clean target/config between test runs to prevent stale credentials #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robfrank merged 1 commit into from
Apr 22, 2026
+1 −0
Merged

test: clean target/config between test runs to prevent stale credentials #3960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test-utils/src/main/java/com/arcadedb/test/TestServerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ public static void checkActiveDatabases(final boolean drop) {

public static void deleteDatabaseFolders(final int totalServers) {
FileUtils.deleteRecursively(new File("./target/databases/"));
FileUtils.deleteRecursively(new File("./target/config/"));

@gemini-code-assist gemini-code-assist Bot Apr 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The method deleteDatabaseFolders now deletes configuration files in addition to database folders. This introduces a side effect that is not reflected in the method's name, which can be misleading for other developers and may lead to unexpected behavior if a test intends to preserve configuration while resetting databases. Consider renaming the method to something more descriptive, such as cleanupTestArtifacts, or moving this logic to a dedicated cleanup method. Additionally, hardcoding the path ./target/config/ makes the cleanup logic fragile as it assumes a specific project structure and working directory.

FileUtils.deleteRecursively(new File(GlobalConfiguration.SERVER_DATABASE_DIRECTORY.getValueAsString() + File.separator));
for (int i = 0; i < totalServers; ++i)
FileUtils.deleteRecursively(new File(GlobalConfiguration.SERVER_DATABASE_DIRECTORY.getValueAsString() + i + File.separator));
Expand Down
Loading