-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GWTChosen doesn't work well with RTL locales. #79
Comments
Could you attach a screenshot ? How do you set the local ? |
Here how it looks like: Now this is how it looks first time I navigate to the view without me doing anything. After selecting an option, it does select it, but the drop menu staying there. When I switch to a LTR locale everything seems fine. I'm setting the locale in the module .xml file as a fallback (default value), but If I set it manually in the url, the same result appears. I'm using: All browsers show the same exact result. |
I have same problem too. Is there any plan to support RTL styles correctly? Thanks. |
Hi, I have corrected this problem which was relative to styling in RTL languages. Only "ChosenImpl.java" and "chosen.css" has been modified. I have also uploaded patched version of gwtchosen-1.1.0 for directly use. I have tested this widget in both single and multiple select modes and with both LTR and RTL languages. URL for these three files: http://www.fileconvoy.com/dfl.php?id=gddeff85f3fa553d39993177429639f9ec7e85ceeb Please consider this patch and merge it to the main repository if is possible (code format of ChosenImpl.java was changed and should be reformatted). Best Regards. |
Hi @ali-jalaal Thanks for the patch. Kind I kindly ask you to create a pull request with your change ? |
Hi @jDramaix As I mentioned in above pull request, when I used the main repository code, widget was worked well in RTL and LTR mode and the problem was in gwtchosen-1.1.0.jar. There is just a small changes in pull request for correcting size of close image in multiple-select mode options. Regards, |
yes we did a change few months ago concerning a bug in LTR mode 9a4ad55 |
@AlQuraian could you confirm that the problem is soved with the last release ? |
I'll do that ASAP, I'm away from home at this time. Thanks guys for the updates. |
It seems that the does not exist anymore. Which is weird cause I am using the same versions! |
Version 1.2.0 and 1.2.1-SNAPSHOT all still have this issue. Had to reopen the issue again. |
The issues appear when I put these two lines in the GWT module file:
|
I'm not sure if they are supposed to be supported or not, anyway, when I tried GWTChosen in a RTL locale the list is always appearing even if I click on an item!
When I switch to English (even without stopping the debugging state) everything works fine.
The text was updated successfully, but these errors were encountered: