Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GWTChosen doesn't work well with RTL locales. #79

Open
AlQuraian opened this issue Apr 27, 2013 · 12 comments
Open

GWTChosen doesn't work well with RTL locales. #79

AlQuraian opened this issue Apr 27, 2013 · 12 comments

Comments

@AlQuraian
Copy link

I'm not sure if they are supposed to be supported or not, anyway, when I tried GWTChosen in a RTL locale the list is always appearing even if I click on an item!

When I switch to English (even without stopping the debugging state) everything works fine.

@jDramaix
Copy link
Contributor

Could you attach a screenshot ? How do you set the local ?

@AlQuraian
Copy link
Author

Here how it looks like:

ar

Now this is how it looks first time I navigate to the view without me doing anything. After selecting an option, it does select it, but the drop menu staying there. When I switch to a LTR locale everything seems fine.

I'm setting the locale in the module .xml file as a fallback (default value), but If I set it manually in the url, the same result appears.

I'm using:
GWT 2.5.1
gwtquery-1.3.3
gwtchosen-1.1.0

All browsers show the same exact result.

@ali-jalaal
Copy link

I have same problem too.

Is there any plan to support RTL styles correctly?

Thanks.

@ali-jalaal
Copy link

Hi,

I have corrected this problem which was relative to styling in RTL languages. Only "ChosenImpl.java" and "chosen.css" has been modified. I have also uploaded patched version of gwtchosen-1.1.0 for directly use.

I have tested this widget in both single and multiple select modes and with both LTR and RTL languages.

URL for these three files: http://www.fileconvoy.com/dfl.php?id=gddeff85f3fa553d39993177429639f9ec7e85ceeb
(If files have been removed, notify me to upload them again)

Please consider this patch and merge it to the main repository if is possible (code format of ChosenImpl.java was changed and should be reformatted).

Best Regards.
Ali Jalal.

@jDramaix
Copy link
Contributor

Hi @ali-jalaal Thanks for the patch. Kind I kindly ask you to create a pull request with your change ?

@ali-jalaal
Copy link

Hi @jDramaix

As I mentioned in above pull request, when I used the main repository code, widget was worked well in RTL and LTR mode and the problem was in gwtchosen-1.1.0.jar.

There is just a small changes in pull request for correcting size of close image in multiple-select mode options.

Regards,
Ali Jalal.

@jDramaix
Copy link
Contributor

jDramaix commented Jul 1, 2013

yes we did a change few months ago concerning a bug in LTR mode 9a4ad55

@jDramaix
Copy link
Contributor

jDramaix commented Jul 1, 2013

@AlQuraian could you confirm that the problem is soved with the last release ?

@AlQuraian
Copy link
Author

I'll do that ASAP, I'm away from home at this time. Thanks guys for the updates.

@AlQuraian
Copy link
Author

It seems that the does not exist anymore. Which is weird cause I am using the same versions!

@AlQuraian
Copy link
Author

Version 1.2.0 and 1.2.1-SNAPSHOT all still have this issue. Had to reopen the issue again.

@AlQuraian AlQuraian reopened this Aug 30, 2013
@AlQuraian
Copy link
Author

The issues appear when I put these two lines in the GWT module file:

<extend-property name="locale" values="ar" />
<set-property-fallback name='locale' value="ar" />

@olafleur olafleur added the bug label Sep 14, 2015
@olafleur olafleur added suggestion and removed bug labels Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants