inc gwt version and update module dtds #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!DOCTYPE module PUBLIC "-//Google Inc.//DTD Google Web Toolkit 2.6.1//EN" | |||
| "https://raw.githubusercontent.com/gwtproject/gwt/2.6.1/distro-source/core/src/gwt-module.dtd"> | |||
| <!-- --> | |||
| <!-- Copyright 2008 Google Inc. --> | |||
There was a problem hiding this comment.
Is this code copyright Google? or is this a cut and paste error?
There was a problem hiding this comment.
Cut and past. We overridden the default behaviour
|
Once the copyright is removed. LGTM |
| @@ -225,7 +225,7 @@ | |||
|
|
|||
| <!-- Maven --> | |||
| <build-helper-maven-plugin.version>1.7</build-helper-maven-plugin.version> | |||
| <gwt-maven-plugin.version>2.6.0</gwt-maven-plugin.version> | |||
| <gwt-maven-plugin.version>2.6.1</gwt-maven-plugin.version> | |||
There was a problem hiding this comment.
If we get rid of the gwt-maven-plugin.version property and just use the gwt.version in its place then it won't be possible to change one and forget the other.
There was a problem hiding this comment.
True, but there some times that it's not in sync.
There was a problem hiding this comment.
Ok I'll leave it then.
meriouma
added a commit
that referenced
this pull request
Jul 10, 2014
inc gwt version and update module dtds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.