Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode embedded paramaters of RouteTokenFormatter #499

Merged
merged 2 commits into from
May 28, 2014
Merged

decode embedded paramaters of RouteTokenFormatter #499

merged 2 commits into from
May 28, 2014

Conversation

rdwallis
Copy link
Contributor

So if you have nameToken = "/myplace/{myparam}/"

and then you set myparam = "Two Words"

Route Token formatter produces the url = "/myplace/Two+Words/"

But then if you request the parameters from that url you get back "Two+Words"

So you've put in "Two Words" and you get back "Two+Words"

This fixes that issue.

@jDramaix
Copy link
Contributor

LGTM. Thanks for this contribution

@olafleur
Copy link
Member

LGTM. @Chris-V ?

@christiangoudreau
Copy link
Member

Could you add a unit test for this before we merge it? I do not want this to be broken in the future.

Thanks,

@rdwallis
Copy link
Contributor Author

ok will do

On 28 May 2014 22:17, christiangoudreau [email protected] wrote:

Could you add a unit test for this before we merge it? I do not want this
to be broken in the future.

Thanks,


Reply to this email directly or view it on GitHubhttps://github.com//pull/499#issuecomment-44458778
.

@rdwallis
Copy link
Contributor Author

ok done, 10 minutes on the patch 40 minutes on code style, will your ide's break if there's trailing whitespace?

@olafleur
Copy link
Member

All the tests seem to pass now.

@christiangoudreau
Copy link
Member

Nope, Build is fine, it will be perfect.

LGTM

@Chris-V
Copy link
Member

Chris-V commented May 28, 2014

Thank you!

Chris-V added a commit that referenced this pull request May 28, 2014
decode embedded paramaters of RouteTokenFormatter
@Chris-V Chris-V merged commit 7a241b3 into ArcBees:master May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants