Rest/Rpc dispatch interoperability #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example? LGTM |
|
There's no example. You just use both dispatchers as you would use them, except that they won't clash together. |
|
LGTM |
|
But we could setup both dispatchers in the CarStore to ensure it keeps working? |
|
Sure |
…erability Conflicts: gwtp-core/gwtp-tester/src/main/java/com/gwtplatform/tester/TestDispatchModule.java
…erability Conflicts: gwtp-core/gwtp-dispatch-common-client/src/main/java/com/gwtplatform/dispatch/client/gin/AbstractDispatchAsyncModule.java gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/rest/client/DefaultRestDispatchCallFactory.java gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/rest/client/RestDispatchCall.java gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/rest/client/gin/RestDispatchAsyncModule.java gwtp-core/gwtp-dispatch-rpc-client/src/main/java/com/gwtplatform/dispatch/rpc/client/DefaultRpcDispatchCallFactory.java gwtp-core/gwtp-dispatch-rpc-client/src/main/java/com/gwtplatform/dispatch/rpc/client/RpcDispatchExecuteCall.java gwtp-core/gwtp-dispatch-rpc-client/src/main/java/com/gwtplatform/dispatch/rpc/client/RpcDispatchUndoCall.java
Conflicts: gwtp-carstore/pom.xml gwtp-carstore/src/main/resources/com/gwtplatform/carstore/SuperDevMode.gwt.xml pom.xml
Updated gwt-jackson
Allow different DispatchHooks for REST and RPC dispatchers
Changed return type of Builder to return correct type
Fixed DispatchHooks binding when using both dispatchers
Added RPC dispatch in CarStore to showcase dispatcher coexistence
meriouma
added a commit
that referenced
this pull request
Jul 30, 2014
Rest/Rpc dispatch interoperability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes makes it possible to use both dispatchers together by binding common interfaces to an annotation (
@RpcBindingand@RestBinding).The auto-format went a bit crazy, but the format is fine so I send it as well.