-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map More than one name token to presenter #346
Conversation
@@ -134,7 +134,7 @@ private void findNameToken(JClassType proxyInterface) | |||
+ NameToken.class.getSimpleName() + ".", null); | |||
throw new UnableToCompleteException(); | |||
} | |||
nameToken = nameTokenAnnotation.value(); | |||
nameTokens = nameTokenAnnotation.value(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename method to findNameTokens. I would also add something to make sure there is at least one NameToken ie:
if (nameTokens.size() == 0) {
logger.log(TreeLogger.ERROR,
"The proxy for '" + presenterInspector.getPresenterClassName() + "' is annotated with '@"
+ NameToken.class.getSimpleName() + "', but has no name token specified.", null);
throw new UnableToCompleteException();
}
We must make sure there is at least one name token, otherwise this looks good to me. Good job :) |
Coudl I close pull request #343 other implementation ? |
Yes, close the other one. Before going any further with this one, I want @PhilBeaudoin to review at least. |
Another thought to this addition, could be useful for those with multiple languages, or support multiple languages in the with the token. Do you think that would be useful? |
Any news about include this patch ? Need probide other changes |
@PhilBeaudoin needs to review this. He's currently in a deadline rush with Chrome. You can provide other PR on top of this one if you have done a new branch on top of this one by comparing the new branch against this branch if you want. |
Change annotation NameToken value to array of name tokens. Change PlaceImpl. For tab content proxy just use first nametoken.
Add dummy javadoc (fix checkstyle)
Thanks for maintaining this PR and sorry for the very long wait. Please remove all the |
Chris, we need those changes, do it once you're done with your other tasks |
Change annotation NameToken value to array of name tokens. Change
PlaceImpl. For tab content proxy just use first nametoken.
Second implementation.