Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PlaceRequest.Builder to build from an existing PlaceRequest #300

Closed
ryankenney opened this issue Aug 2, 2013 · 5 comments
Closed
Milestone

Comments

@ryankenney
Copy link

The com.gwtplatform.mvp.client.proxy.PlaceRequest.Builder implementation in GWTP 1.0 doesn't allow you to build from an existing PlaceRequest. Our common use case is to query com.gwtplatform.mvp.client.proxy.PlaceManager.getCurrentPlaceRequest() and then
add/change something.

I propose a new constructor for PlaceRequest.Builder:

PlaceRequest.Builder(PlaceRequest request)

@branflake2267
Copy link
Contributor

Thanks for reporting the issue.

@bmoritz
Copy link
Contributor

bmoritz commented Aug 11, 2013

Opened PR #304 to enhance PlaceRequest Builder accordingly

@christiangoudreau
Copy link
Member

Please update documentation to include your new feature: https://github.com/ArcBees/GWTP/wiki/URL-Parameters

Feel free to improve if you find something to improve :D (Boy scout rule)

@bmoritz
Copy link
Contributor

bmoritz commented Aug 13, 2013

Done

@branflake2267
Copy link
Contributor

Good job! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants