Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make arv_buffer_get_status and possibly arv_stream_try_pop_buffer robust against "ARV_IS_BUFFER failed" issue #967

Open
denglerchr opened this issue Dec 13, 2024 · 3 comments
Labels
1. bug Problems, incorrect behavior or appearance

Comments

@denglerchr
Copy link

Is your feature request related to a problem? Please describe.
Yes, the feature request is related to #853 . It seems that due to network issues/camera issues, invalid buffers can be received and calling, e.g., arv_buffer_get_status throws an error "assertion ARV_IS_BUFFER failed".

Describe the solution you'd like
Instead of throwingn an error, arv_buffer_get_status could return a status indicating a broken buffer.
For arv_stream_try_pop_buffer, I am less sure if it is the right solution, but possibly this would return NULL instead of the buffer in case of weird broken buffers.

Describe alternatives you've considered
I found no alternative, I currently need to restart the acquisition program when this happens.

Additional context
I am using Aravis through a wrapper written in Julia (https://github.com/jwahlstrand/AravisCameras.jl).
Current workflow is calling arv_stream_try_pop_buffer followed by check for NULL followed by a check with arv_buffer_get_status where I then often receive an error.

@jwahlstrand
Copy link
Contributor

I think these errors are caused by a mistake in a Julia package.

@EmmanuelP
Copy link
Contributor

@jwahlstrand , what makes you think it comes from a julia package ?

@EmmanuelP EmmanuelP added the 1. bug Problems, incorrect behavior or appearance label Dec 14, 2024
@jwahlstrand
Copy link
Contributor

Sorry for the noise, I think there are multiple things going on -- one of which is a bug in the Julia package for GObject introspection...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. bug Problems, incorrect behavior or appearance
Projects
None yet
Development

No branches or pull requests

3 participants