diff --git a/src/Polly.Core/Retry/RetryHelper.cs b/src/Polly.Core/Retry/RetryHelper.cs index d5b66a51210..8520b50ec32 100644 --- a/src/Polly.Core/Retry/RetryHelper.cs +++ b/src/Polly.Core/Retry/RetryHelper.cs @@ -54,7 +54,7 @@ internal static TimeSpan ApplyJitter(TimeSpan delay, Func randomizer) return TimeSpan.FromMilliseconds(newDelay); } -#pragma warning disable IDE0047 // Remove unnecessary parentheses which offer less mental gymnastics +#pragma warning restore IDE0047 // Remove unnecessary parentheses which offer less mental gymnastics /// /// Generates sleep durations in an exponentially backing-off, jittered manner, making sure to mitigate any correlations. diff --git a/test/Polly.Core.Tests/Retry/RetryHelperTests.cs b/test/Polly.Core.Tests/Retry/RetryHelperTests.cs index c2529eeb8a7..b74d5224ae4 100644 --- a/test/Polly.Core.Tests/Retry/RetryHelperTests.cs +++ b/test/Polly.Core.Tests/Retry/RetryHelperTests.cs @@ -267,13 +267,13 @@ public void ExponentialWithJitter_EnsureRandomness() [FsCheck.Xunit.Property(Arbitrary = [typeof(Arbitraries)], MaxTest = 10_000)] public void ApplyJitter_Meets_Specification(TimeSpan value) { - var delta = value / 2; + var delta = value / 4; var floor = value - delta; var ceiling = value + delta; var actual = RetryHelper.ApplyJitter(value, RandomUtil.NextDouble); - actual.ShouldBeGreaterThan(floor); + actual.ShouldBeGreaterThanOrEqualTo(floor); actual.ShouldBeLessThanOrEqualTo(ceiling); } @@ -283,13 +283,13 @@ public void DecorrelatedJitterBackoffV2_Meets_Specification(TimeSpan value, int var rawCeiling = value.Ticks * Math.Pow(2, attempt) * 4; var clamped = (long)Math.Clamp(rawCeiling, value.Ticks, TimeSpan.MaxValue.Ticks); - var floor = value; + var floor = TimeSpan.Zero; var ceiling = TimeSpan.FromTicks(clamped - 1); var _ = default(double); var actual = RetryHelper.DecorrelatedJitterBackoffV2(attempt, value, ref _, RandomUtil.NextDouble); - actual.ShouldBeGreaterThan(floor); + actual.ShouldBeGreaterThanOrEqualTo(floor); actual.ShouldBeLessThanOrEqualTo(ceiling); } #endif @@ -318,7 +318,7 @@ public static class Arbitraries public static Arbitrary PositiveInteger() { var minimum = 1; - var maximum = 2056; + var maximum = 2048; var generator = Gen.Choose(minimum, maximum); return Arb.From(generator);