Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apicurio code styling #5

Open
lordrip opened this issue Aug 13, 2024 · 2 comments
Open

Update Apicurio code styling #5

lordrip opened this issue Aug 13, 2024 · 2 comments

Comments

@lordrip
Copy link

lordrip commented Aug 13, 2024

Context

Coming from: #4

Also, can we apply Apicurio code styling if there are no objections (expecting there might be)?

Originally posted by @EricWittmann in #4 (comment)

Goal

Since the last eslint 9.x release, the configuration file formatted changed, introducing a breaking change, more information in the release post: https://eslint.org/blog/2024/04/eslint-v9.0.0-released/

The goal is to have a compatible version of the apicurio code style that works with eslint 9.x. and use it in this project

Proposal

  1. Copy the .eslintrc file into this project
  2. Make the necessary updates to make it work with eslint 9.x
  3. Once that's done, push this change upstream and release a new version**

** Confirm with @EricWittmann if the latter is possible, as this could affect other consumers

@EricWittmann
Copy link
Member

Pushing upstream and releasing is no problem.

@lordrip
Copy link
Author

lordrip commented Aug 13, 2024

@EricWittmann where is that file located?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants