Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove italics from last PR [APE-1168] #1528

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jul 6, 2023

What I did

fixes: #

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@vany365 vany365 changed the title fix: remove italics from last PR fix: remove italics from last PR [APE-1168] Jul 6, 2023
@banteg
Copy link
Contributor

banteg commented Jul 6, 2023

reason: italics would render as inverse text (black text on white background) in the default tmux config. it requires TERM to be set to xterm-256color to render properly. screen-256color doesn't support italics.

@antazoey
Copy link
Member Author

antazoey commented Jul 6, 2023

@banteg also suggested to include ipt names as well; we are doing that now, but leverage ethpm-types

@antazoey
Copy link
Member Author

antazoey commented Jul 6, 2023

mypy is failing from latest click upgrade

@antazoey
Copy link
Member Author

antazoey commented Jul 6, 2023

it is easier to just pin click then try to resolve all the "issues" pallets/click#2558

@antazoey antazoey merged commit 4787894 into ApeWorX:main Jul 6, 2023
@antazoey antazoey deleted the fix/no-italics branch July 6, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants