Renaming config

Author: Neamar

Diff for: README.md

@@ -6,7 +6,7 @@ AnyFetch Hydrater for classic office files
 # How to install?
 ```sh
 sudo apt-get install python-software-properties
-sudo apt-add-repository ppa:libreoffice/libreoffice-4-1
+sudo apt-add-repository ppa:libreoffice/libreoffice-4-2
 sudo apt-get update
 sudo apt-get install libreoffice -y
 npm install

Diff for: config/configuration.js

@@ -4,29 +4,26 @@
 
 // node_env can either be "development" or "production"
 var node_env = process.env.NODE_ENV || "development";
-var default_port = 8000;
-
-var default_office_version = "4.0";
+var defaultPort = 8000;
 
 // URL of pdf hydrater
-var default_pdf_hydrater_url = "http://pdf.hydrater.anyfetch.com";
+var defaultPdfHydraterUrl = "http://pdf.hydrater.anyfetch.com";
 
 // URL of office hydrater
-var default_office_hydrater_url = 'http://office.hydrater.anyfetch.com';
+var defaultOfficeHydraterUrl = 'http://office.hydrater.anyfetch.com';
 
 // Number of office instance to run simultaneously per cluster
-var default_concurrency = 1;
+var defaultConcurrency = 1;
 
 if(node_env === "production") {
-  default_port = 80;
+  defaultPort = 80;
 }
 
 // Exports configuration
 module.exports = {
   env: node_env,
-  port: process.env.PORT || default_port,
-  office_version: process.env.OFFICE_VERSION || default_office_version,
-  concurrency: process.env.OFFICE_CONCURRENCY || default_concurrency,
-  pdf_hydrater_url: process.env.PDF_HYDRATER_URL || default_pdf_hydrater_url,
-  office_hydrater_url: process.env.OFFICE_HYDRATER_URL || default_office_hydrater_url
+  port: process.env.PORT || defaultPort,
+  concurrency: process.env.OFFICE_CONCURRENCY || defaultConcurrency,
+  pdfHydraterUrl: process.env.PDF_HYDRATER_URL ||defaultPdfHydraterUrl,
+  officeHydraterUrl: process.env.OFFICE_HYDRATER_URL || defaultOfficeHydraterUrl
 };

Diff for: lib/index.js

@@ -99,9 +99,9 @@ module.exports = function(path, document, changes, cb) {
       pdfDocument.metadata.path = document.metadata.path;
 
       var payload = {
-        url: config.pdf_hydrater_url + "/hydrate",
+        url: config.pdfHydraterUrl + "/hydrate",
         json: {
-          file_path: config.office_hydrater_url + "/document?path=" + pdfFile.replace('/tmp/', ''),
+          file_path: config.officeHydraterUrl + "/document?path=" + pdfFile.replace('/tmp/', ''),
           callback: finalCb.urlCallback,
           document: pdfDocument
         }

Diff for: test/server.js

@@ -22,8 +22,8 @@ describe('Test office results', function() {
   it('should call the pdf hydrater before sending results', function(done) {
     // Update our pdf hydrater
     officeHydrater.listen(1339);
-    config.pdf_hydrater_url = 'http://localhost:1337';
-    config.office_hydrater_url = 'http://localhost:1339';
+    config.pdfHydraterUrl = 'http://localhost:1337';
+    config.officeHydraterUrl = 'http://localhost:1339';
 
     var pdfHydrater = restify.createServer();
     pdfHydrater.use(restify.queryParser());
@@ -92,8 +92,8 @@ describe('Test office results', function() {
 
   it('should transform to PDF', function(done) {
     // Update our pdf hydrater
-    config.pdf_hydrater_url = 'http://localhost:1337';
-    config.office_hydrater_url = 'http://localhost:1339';
+    config.pdfHydraterUrl = 'http://localhost:1337';
+    config.officeHydraterUrl = 'http://localhost:1339';
 
     var pdfHydrater = restify.createServer();
     pdfHydrater.use(restify.queryParser());