Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to /v3 #6

Open
Sean-Der opened this issue Feb 21, 2021 · 4 comments
Open

Upgrading to /v3 #6

Sean-Der opened this issue Feb 21, 2021 · 4 comments

Comments

@Sean-Der
Copy link

Hey @Antonito

Would you be interested in upgrading to /v3?

I recommend this project to others on File Transfer/DataChannel usage. So would love for them to start off with a /v3. If you are interested I can submit a PR in a few weeks. Want to check before I attempt it though. It should be only one change around Trickle ICE

thanks!

@Antonito
Copy link
Owner

Hey @Sean-Der,

I hope you're doing well!
Sure! I can do it myself, some parts of the project are really messy – it could use a refacto. I'll give it a look tonight :)

@Antonito
Copy link
Owner

I opened #7. It now uses /v3 – which drastically increased performances!

I'll try to merge it by the end of the week, there is still some work to be done (update tests, clean some parts...) but it's functional :)

@Sean-Der
Copy link
Author

That is fantastic news @Antonito thanks for doing that! So excited to here about the performance improvements as well. Been trying hard to improve things, hard to keep up with what has happened though

But everything is good here. How goes your other work? Haven't heard from you in a while, hope it is all going well! Really reach out anytime with any question.

@xdeng
Copy link

xdeng commented Dec 9, 2022

Looking forward to merging into the main project
The transmission speed of the v2 version is not very good under some networks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants