Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behaviour of exclusion classes with HTML filter #16

Open
odie2 opened this issue Sep 25, 2015 · 1 comment
Open

Incorrect behaviour of exclusion classes with HTML filter #16

odie2 opened this issue Sep 25, 2015 · 1 comment
Labels
bug to confirm Reproduction of issue is pending

Comments

@odie2
Copy link
Contributor

odie2 commented Sep 25, 2015

Hi,

I just discovered that filter apply_filters( 'bj_lazy_load_html', $content ) (used in add_filter( 'the_content', 'function' );) behaves incorrectly.

  1. When I would to exclude image (because it's slider's lazyloading), the default no-lazy class takes no effect, so I have doubled noscript tag and broken image src.
  2. When I set any image the no-lazy class in post's editor (by Insert Media), the whole images on the page are no lazyloaded.

I think that problem begins in _get_content_haystack in bj-lazy-load\inc\class-bjll.php, but I have no idea how to fix it.

Greetings

@jan-san jan-san added bug to confirm Reproduction of issue is pending labels Jul 10, 2019
@jan-san
Copy link
Collaborator

jan-san commented Jul 10, 2019

The issues were possibly caused by RegEx issues fixed in b360afd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to confirm Reproduction of issue is pending
Projects
None yet
Development

No branches or pull requests

2 participants