Change Color to be a struct rather than an enum #629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of the type and eliminates the need to branch to read from it, increasing its usability, and bringing it closer to the conceptual Color type used by most libraries and SDL itself.
This is a breaking change, but the
RGB
andRGBA
constructor functions should make the impact minimal for anybody not manually matching.I suppose I should make a note about some of the other inconsistencies;
raw()
is private, "because reasons", butColor
implementsInto<ll::SDL_Color>
meaning the conversion is publicly available as safe anyways, and thettf
module seems to independently re-implement this function for no discernible reason. This could perhaps also be improved.