Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost </div> in 404.html #21

Closed
sauerj opened this issue Oct 16, 2018 · 3 comments
Closed

Lost </div> in 404.html #21

sauerj opened this issue Oct 16, 2018 · 3 comments
Assignees
Labels
bug report Something isn't working reproduced Added when a bug has been confirmed

Comments

@sauerj
Copy link
Contributor

sauerj commented Oct 16, 2018

By inspecting the source of the generated 404.html, Firefox noticed a lost </div> just after the </section> from layouts/404.html

This is caused by layouts/partials/footer.html:2 which is closing the "content" <div> which does not exist in layouts/404.html

@AngeloStavrow AngeloStavrow self-assigned this Oct 17, 2018
@AngeloStavrow AngeloStavrow added the bug report Something isn't working label Oct 17, 2018
@AngeloStavrow
Copy link
Owner

Thanks for your report! I'll fix this shortly, unless you have a PR ready for submitting.

@sauerj
Copy link
Contributor Author

sauerj commented Oct 17, 2018

No, unfortunately I do not have a PR ready. I was not sure how you want to address this issue.

@AngeloStavrow
Copy link
Owner

That's fair enough. Let me consider how to best approach this. The more I think about it, I realize that I'm not overly fond of having a random </div> at the top of a partial.

@AngeloStavrow AngeloStavrow added the reproduced Added when a bug has been confirmed label Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something isn't working reproduced Added when a bug has been confirmed
Projects
None yet
Development

No branches or pull requests

2 participants