Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AttrConfig as descriptor extension #68

Open
Anaminus opened this issue May 7, 2022 · 0 comments
Open

Refactor AttrConfig as descriptor extension #68

Anaminus opened this issue May 7, 2022 · 0 comments
Labels
breaking Not backward-compatible enhancement New feature or request

Comments

@Anaminus
Copy link
Owner

Anaminus commented May 7, 2022

Currently, there are several locations where a descriptor can be passed in, but an AttrConfig cannot. One option would be to combine RootDesc and AttrConfig under a common "config" type. However, AttrConfig only contains simple configuration data, which is very suitable for what extensions are designed for.

So, instead of maintaining a separate type, AttrConfig will be removed, and reimplemented as a descriptor extension:

{
	"$rbxmkFields": {
		"Attributes": {
			"Property": "AttributesSerialize"
		}
	}
}
@Anaminus Anaminus added enhancement New feature or request breaking Not backward-compatible labels May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Not backward-compatible enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant