We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When root isn't set to "/", I've noticed some unexpected behaviour with regard to the root url when it has a query string.
root
An example:
const Router = AmpersandRouter.extend({ routes: { "": "index", "(*path)": "catchAll" }, index() { //never fires }, catchAll(path, query) { console.log(pathname);//path results in the query string instead } }); const router = new Router(); router.history.start({ pushState: true, root: "/app" });
When starting the page at, say /app?foo=bar, path incorrectly results in "foo=bar", which isn't right. router.history.fragment also reports "foo=bar".
/app?foo=bar
path
"foo=bar"
router.history.fragment
However, staring the page at /app/second?foo=bar, path correctly results in "/second"
/app/second?foo=bar
"/second"
The text was updated successfully, but these errors were encountered:
dhritzkiv
No branches or pull requests
When
root
isn't set to "/", I've noticed some unexpected behaviour with regard to the root url when it has a query string.An example:
When starting the page at, say
/app?foo=bar
,path
incorrectly results in"foo=bar"
, which isn't right.router.history.fragment
also reports"foo=bar"
.However, staring the page at
/app/second?foo=bar
,path
correctly results in"/second"
The text was updated successfully, but these errors were encountered: