You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed a bug when dealing with encoded percent signs in urls. Take the following simple example:
store/search/<query>
with a query value of % and proper encoding this gets
store/search/%25
When i pass this as a route to the navigate function the fragment gets changed to store/search/%by the decodeURI call in the following line. Changing the URL fragment on navigation appears like a bug to me. Based on navigating around the code a bit and the comment for that function saying that the caller is responsible for proper encoding I wonder if the decodeURI call is actually necessary.
Any thoughts on that? Thanks.
The text was updated successfully, but these errors were encountered:
I noticed a bug when dealing with encoded percent signs in urls. Take the following simple example:
with a query value of
%
and proper encoding this getsWhen i pass this as a route to the navigate function the fragment gets changed to
store/search/%
by the decodeURI call in the following line. Changing the URL fragment on navigation appears like a bug to me. Based on navigating around the code a bit and the comment for that function saying that the caller is responsible for proper encoding I wonder if the decodeURI call is actually necessary.Any thoughts on that? Thanks.
The text was updated successfully, but these errors were encountered: