Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If ascent_actions.yaml exists, it overrides what the user passes to Ascent::execute() #1375

Open
agcapps opened this issue Aug 29, 2024 · 2 comments

Comments

@agcapps
Copy link

agcapps commented Aug 29, 2024

Ascent::execute() lets the user pass in a Node with actions:
https://github.com/Alpine-DAV/ascent/blob/develop/src/libs/ascent/ascent.cpp#L371

But then, if CheckForSettingsFile() finds a file named ascent_actions.yaml, that file replaces whatever the user passed to execute():
https://github.com/Alpine-DAV/ascent/blob/develop/src/libs/ascent/ascent.cpp#L135

This is unpleasantly surprising, at least. I think if a user calls execute() passing in actions, Ascent should ignore its default.

@cyrush
Copy link
Member

cyrush commented Aug 29, 2024

@agcapps the most common use case is actually folks overriding at runtime with a external file.

That's b/c users aren't usually compiling the code themselves and they craft yaml files for their use case.

We should improve our docs for the opposite case (always want to ignore the external file) and also the way we select between these cases, since its confusing.

@cyrush
Copy link
Member

cyrush commented Sep 3, 2024

Also consider a precedence option as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants