Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Allsky fixes for Bookworm #3012

Closed
minichate opened this issue Oct 13, 2023 · 84 comments
Closed

[BUG] Allsky fixes for Bookworm #3012

minichate opened this issue Oct 13, 2023 · 84 comments
Labels
Need user response Waiting for user to respond

Comments

@minichate
Copy link
Contributor

Environment

  • Camera: ASI178MC
  • OS: Raspbian 12
  • Allsky version: v2023.05.01_03
  • Pi 4B with 8GB RAM

Bug Description

Unable to build src/ directory due to FPU error:

Building capture_ZWO.o ...
cc1plus: error: '-mfloat-abi=hard': selected architecture lacks an FPU
make: *** [Makefile:131: capture_ZWO.o] Error

Log / configuration files

make_all.log

@minichate
Copy link
Contributor Author

minichate commented Oct 13, 2023

I can get farther by changing:

diff --git a/src/Makefile b/src/Makefile
index af794304..5ce8db98 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -69,7 +69,6 @@ else ifeq ($(arch), arm64)
 else           # $(platform) = armv7l or $(arch) = armhf
   CC = arm-linux-gnueabihf-g++
   AR= arm-linux-gnueabihf-ar
-  CFLAGS += -march=armv7 -mthumb
   ZWOSDK = -Llib/armv7 -I./include
 endif

Which makes me believe this is an armv7 architecture problem, perhaps?

@EricClaeys
Copy link
Collaborator

Are you running Buster or Bullseye? I am not sure which is version 12.
And 32 or 64 bits?

@minichate
Copy link
Contributor Author

minichate commented Oct 13, 2023

bookworm -- the latest version! https://www.raspberrypi.com/news/bookworm-the-new-version-of-raspberry-pi-os/ 32-bits

@minichate
Copy link
Contributor Author

I'll file an issue for the other bookworm related bugs I've found around python dependencies not working with the system Python (3.11) bundled on that OS!

@Alex-developer
Copy link
Collaborator

Alex-developer commented Oct 13, 2023

I'll file an issue for the other bookworm related bugs I've found around python dependencies not working with the system Python (3.11) bundled on that OS!

Are you using 32 or 64bit? (Lite or Desktop)

I am working on a fix for Bookworm at the moment. Once its done I'll let you know if you want to give it a test.

The Pi camera capture module builds fine, I'll take a look at the ZWO one once I have sorted the python issues.

If you post a list of fixes you make that would be very helpful :-)

Thanks

Alex

@EricClaeys EricClaeys changed the title [BUG] Unable to build due to -mfloat-abi=hard [BUG] Allsky fixes for Bookworm Oct 13, 2023
@EricClaeys
Copy link
Collaborator

@minichate, Christopher, if you post any more Bookworm-related things, please use this Issue, which I renamed.

@s-valve
Copy link

s-valve commented Oct 14, 2023

Hi guys, i've got the same failure and have no idea how to solve. I have to say, I'm no familiar with Linux... Maybe you can give me a hint what to change in the makefile or any other location. thanks, Martin

Used Raspi OS:
Release date: October 10th 2023
System: 32-bit
Kernel version: 6.1
Debian version: 12 (bookworm)
Size: 2,606MB

make_all.log

@Alex-developer
Copy link
Collaborator

Hi guys, i've got the same failure and have no idea how to solve. I have to say, I'm no familiar with Linux... Maybe you can give me a hint what to change in the makefile or any other location. thanks, Martin

Used Raspi OS: Release date: October 10th 2023 System: 32-bit Kernel version: 6.1 Debian version: 12 (bookworm) Size: 2,606MB

make_all.log

There are a few issues with Bookworm that I am working on. As soon as I have a working installation I will update this issue

Cheers

Alex

@s-valve
Copy link

s-valve commented Oct 14, 2023

Merci

@EricClaeys
Copy link
Collaborator

@s-valve you can always install Bullseye.

@Alex-developer
Copy link
Collaborator

Just a quick update.

I have a version that now runs on Bookworm. Next stage is to get it tested fully then we can think about releasing it

Alex

@Jonk2
Copy link

Jonk2 commented Oct 15, 2023

@Alex-developer I have a fresh 32bit bookworm lite I've just installed, only to find out I cannot pip any 3rd party pythhon libraries any more.

Whilst I try and get my head round that, I'll be happy to test your new bookworm-proof allsky! I have nothing to lose if there are any issues.

Will it be put into the dev branch?

One thing I would suggest in general, is can the installer run without having to plug in a camera? If so, I personally would prefer that, as I often bring the test pi indoors, leaving the camera outside.

@Alex-developer
Copy link
Collaborator

@Alex-developer I have a fresh 32bit bookworm lite I've just installed, only to find out I cannot pip any 3rd party pythhon libraries any more.

Whilst I try and get my head round that, I'll be happy to test your new bookworm-proof allsky! I have nothing to lose if there are any issues.

Will it be put into the dev branch?

One thing I would suggest in general, is can the installer run without having to plug in a camera? If so, I personally would prefer that, as I often bring the test pi indoors, leaving the camera outside.

The Point-Release-4 has changes for Bookworm - Please bear in mind that this is NOT fully tested yet. I have installed it on a few Pi's and it installs ok, there is a dev branch for the extra modules that also supports Bookworm

Once you have the new version to add any new python modules you will need to put them in the venv so something like

source /home/pi/allsky/venv/bin/activate

pip3 whatever module

deactivate

I'll leave @EricClaeys to answer the question about the camera as thats his area really.

Cheers

Alex

@Jonk2
Copy link

Jonk2 commented Oct 15, 2023

Ok I see the dev branch is newer - I'll try that one, see how it goes.

@EricClaeys
Copy link
Collaborator

@Jonk2 please do NOT try the dev branch for Allsky. It is not ready.

We changed the installer in the last major release to require that the camera be connected so it could determine what brand and model was being used and then set the default, minimum, and maximum values in the WebUI. It also solved other problems people were having.
Can you explain more why it would be beneficial to not require it to be plugged in during installation? I can't think of any use case for that.

Eric

@EricClaeys EricClaeys added the Need user response Waiting for user to respond label Oct 16, 2023
@varunmehta
Copy link

@Alex-developer, @EricClaeys & @Jonk2

Successful able to start building (off master) on bookworm (other issues still there, working on it), here are the steps I followed;

  1. Install venv
sudo apt-get install python3.11-venv
  1. Then create env with all site-packages
cd allsky 
python -m venv --system-site-packages env
source env/bin/activate
  1. The terminal prompt changes to env
(env) pi@allsky:~/allsky $ 
  1. Execute ./install.sh

new log with venv

* Installing PHP modules.
* Installing other PHP dependencies.
* Installing Python_dependencies:
*    === Package #  1 of 15: [numpy>=1.25.0]
*    === Package #  2 of 15: [opencv-python<=4.6.0.66]
*    === Package #  3 of 15: [Pillow]
*    === Package #  4 of 15: [pyephem]
... 

old log without venv on bookworm

* Installing Python_dependencies:
*    === Package #  1 of 15: [numpy>=1.25.0]

*** ERROR:
**********
Python_dependencies [numpy>=1.25.0] failed
**********

* The full log file is in /home/pi/allsky/config/installation_logs/Python_dependencies.1.log
The end of the file is:

    For more information visit http://rptl.io/venv

Also refer https://www.raspberrypi.com/documentation/computers/os.html#python-on-raspberry-pi

Now scipy is failing

So got bookworm to start building with that, but scipy is acting up, working to debug that

 × Building wheel for scipy (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [920 lines of output]
      setup.py:563: DeprecationWarning:

        `numpy.distutils` is deprecated since NumPy 1.23.0, as a result
        of the deprecation of `distutils` itself. It will be removed for
        Python >= 3.12. For older Python versions it will remain present.
        It is recommended to use `setuptools < 60.0` for those Python versions.
        For more details, see:
          https://numpy.org/devdocs/reference/distutils_status_migration.html

Adding info if anyone else wants to continue from here, will update as I get further along...

@Alex-developer
Copy link
Collaborator

Thanks for that - there is a branch point-release-4 that contains a 'working' install for bookworm but it's not been fully tested. Please feel free to give it a try and see if I have missed anything

Cheers

Alex

@Sundancer78
Copy link

Scipy doesn't work for me either...

How is the Point-Release-4 branch installed?

@EricClaeys
Copy link
Collaborator

On the git clone ... command line, add --branch Point-Release-4.
Keep in mind we have not tested it as a release, although the updates have been tested by themselves.

@Jonk2
Copy link

Jonk2 commented Oct 21, 2023

Can you explain more why it would be beneficial to not require it to be plugged in during installation? I can't think of any use case for that.

@EricClaeys I have 2 systems, 1 outside on the roof with the Pi being relatively inaccessible - this is running an older Allsky that I only update when I'm happy to.

The other PI is in the ROR shed, over PoE, with a fixed camera. Quite often I need to power down the PI and bring it in as I don't have remote power on it yet. As it's a test PI, I often bring it in to write a new OS and bringing in the camera too is not sensible for me.

@Alex-developer

I've tried your suggestions, ran the installation script (with env at the prompt) and I have this as a result:

(env) pi@rorpi:~ $ cd allsky
(env) pi@rorpi:~/allsky $ ./install.sh

  • STARTING INSTALLATON AT Sat 21 Oct 14:34:34 BST 2023.

*** Welcome to the Allsky Installer! ***


  • ZWO camera found.
  • Using ZWO camera.
  • Size of current swap (100 MB) is sufficient; no change needed.
    mount: (hint) your fstab has been modified, but systemd still uses
    the old version; use 'systemctl daemon-reload' to reload.
  • /home/pi/allsky/tmp is now in memory.

*** NOTICE:


The following steps can take up to an hour depending on the speed of your Pi
and how many of the necessary dependencies are already installed.
You will see progress messages throughout the process.
At the end you will be prompted again for additional steps.


  • Installing the web server.
  • Installing dependencies.
  • Preparing Allsky commands.

*** ERROR:


Compile failed


  • The full log file is in /home/pi/allsky/config/installation_logs/make_all.log
    The end of the file is:
    Building capture_ZWO.o ...
    cc1plus: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
    make[1]: *** [Makefile:131: capture_ZWO.o] Error 1
    make[1]: Leaving directory '/home/pi/allsky/src'
    make: *** [Makefile:24: all] Error 2

  • ENDING INSTALLATON AT Sat 21 Oct 14:38:40 BST 2023.

It's worth noting that I installed the lite version of bookworm as I have no need for the desktop environment. I had to install python-full (1st 'huh?' moment), git wasn't recognised as a command and am still nonethewiser how to install '3rd party' python packages in a venv, but I'll do some reading.

Is the lite version causing these issues? (Missing packages and "cc1plus: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU")

I've looked up that message and there are a lot of results, some pre-bookworm by the looks of it.

The pi is a 4B 8GB and I'm running the os from an m.2/usb3 combo.

Allsky logs attached.

lighttpd.install.log
make_all.log
make_deps.log
install.sh.log
status.txt

@Alex-developer
Copy link
Collaborator

Can you explain more why it would be beneficial to not require it to be plugged in during installation? I can't think of any use case for that.

@EricClaeys I have 2 systems, 1 outside on the roof with the Pi being relatively inaccessible - this is running an older Allsky that I only update when I'm happy to.

The other PI is in the ROR shed, over PoE, with a fixed camera. Quite often I need to power down the PI and bring it in as I don't have remote power on it yet. As it's a test PI, I often bring it in to write a new OS and bringing in the camera too is not sensible for me.

@Alex-developer

I've tried your suggestions, ran the installation script (with env at the prompt) and I have this as a result:

(env) pi@rorpi:~ $ cd allsky
(env) pi@rorpi:~/allsky $ ./install.sh

  • STARTING INSTALLATON AT Sat 21 Oct 14:34:34 BST 2023.

*** Welcome to the Allsky Installer! ***

  • ZWO camera found.
  • Using ZWO camera.
  • Size of current swap (100 MB) is sufficient; no change needed.
    mount: (hint) your fstab has been modified, but systemd still uses
    the old version; use 'systemctl daemon-reload' to reload.
  • /home/pi/allsky/tmp is now in memory.

*** NOTICE:

The following steps can take up to an hour depending on the speed of your Pi
and how many of the necessary dependencies are already installed.
You will see progress messages throughout the process.
At the end you will be prompted again for additional steps.

  • Installing the web server.
  • Installing dependencies.
  • Preparing Allsky commands.

*** ERROR:

Compile failed

  • The full log file is in /home/pi/allsky/config/installation_logs/make_all.log
    The end of the file is:
    Building capture_ZWO.o ...
    cc1plus: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
    make[1]: *** [Makefile:131: capture_ZWO.o] Error 1
    make[1]: Leaving directory '/home/pi/allsky/src'
    make: *** [Makefile:24: all] Error 2
  • ENDING INSTALLATON AT Sat 21 Oct 14:38:40 BST 2023.

It's worth noting that I installed the lite version of bookworm as I have no need for the desktop environment. I had to install python-full (1st 'huh?' moment), git wasn't recognised as a command and am still nonethewiser how to install '3rd party' python packages in a venv, but I'll do some reading.

Is the lite version causing these issues? (Missing packages and "cc1plus: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU")

I've looked up that message and there are a lot of results, some pre-bookworm by the looks of it.

The pi is a 4B 8GB and I'm running the os from an m.2/usb3 combo.

Allsky logs attached.

lighttpd.install.log make_all.log make_deps.log install.sh.log status.txt

I think you are still using the master branch try the following on a clean install of Bookworm (Doesn't matter which one, the git install is ONLY required for the lite versions but won't hurt to run it on a desktop version)

sudo apt install git
git clone https://github.com/thomasjacquin/allsky.git
cd allsky
git checkout Point-Release-4
./install.sh

There is now a check in the master branch that will warn you ig you are trying to install on Bookworm

@Jonk2
Copy link

Jonk2 commented Oct 21, 2023

I ran git clone --branch Point-Release-4 https://github.com/thomasjacquin/allsky.git then python -m venv --system-site-packages env etc.

@Alex-developer
Copy link
Collaborator

No need for any of that. The Point release 4 does everything for you. Just checkout the branch and run the install as per normal

@Jonk2
Copy link

Jonk2 commented Oct 21, 2023

Ok, am writing a fresh PiOS Bookworm Lite 32Bit now, then will try to install allsky before I touch anything else!

@Jonk2
Copy link

Jonk2 commented Oct 21, 2023

Ok, new PI OS Bookworm Lite 32Bit installed.

Carried out the instructions as above, same result:

pi@RORPi:~ $ git clone https://github.com/thomasjacquin/allsky.git
Cloning into 'allsky'...
remote: Enumerating objects: 25228, done.
remote: Counting objects: 100% (470/470), done.
remote: Compressing objects: 100% (271/271), done.
remote: Total 25228 (delta 237), reused 387 (delta 189), pack-reused 24758
Receiving objects: 100% (25228/25228), 113.01 MiB | 13.50 MiB/s, done.
Resolving deltas: 100% (15812/15812), done.
pi@RORPi:~ $ cd allsky
pi@RORPi:/allsky $ git checkout Point-Release-4
branch 'Point-Release-4' set up to track 'origin/Point-Release-4'.
Switched to a new branch 'Point-Release-4'
pi@RORPi:
/allsky $ ./install.sh

  • You need to TYPE 'yes' to continue the installation.
    This is to make sure you read it.

pi@RORPi:~/allsky $ ./install.sh

  • STARTING INSTALLATON AT Sat 21 Oct 16:11:24 BST 2023.

*** Welcome to the Allsky Installer! ***


  • ZWO camera found.
  • Using ZWO camera.
  • Size of current swap (100 MB) is sufficient; no change needed.
    mount: (hint) your fstab has been modified, but systemd still uses
    the old version; use 'systemctl daemon-reload' to reload.
  • /home/pi/allsky/tmp is now in memory.

*** NOTICE:


The following steps can take up to an hour depending on the speed of your Pi
and how many of the necessary dependencies are already installed.
You will see progress messages throughout the process.
At the end you will be prompted again for additional steps.


  • Installing the web server.
  • Installing dependencies.
  • Preparing Allsky commands.

*** ERROR:


Compile failed


  • The full log file is in /home/pi/allsky/config/installation_logs/make_all.log
    The end of the file is:
    Building capture_ZWO.o ...
    cc1plus: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
    make[1]: *** [Makefile:131: capture_ZWO.o] Error 1
    make[1]: Leaving directory '/home/pi/allsky/src'
    make: *** [Makefile:24: all] Error 2

  • ENDING INSTALLATON AT Sat 21 Oct 16:15:35 BST 2023.

@Alex-developer
Copy link
Collaborator

Ok, new PI OS Bookworm Lite 32Bit installed.

Carried out the instructions as above, same result:

pi@RORPi:~ $ git clone https://github.com/thomasjacquin/allsky.git
Cloning into 'allsky'...
remote: Enumerating objects: 25228, done.
remote: Counting objects: 100% (470/470), done.
remote: Compressing objects: 100% (271/271), done.
remote: Total 25228 (delta 237), reused 387 (delta 189), pack-reused 24758
Receiving objects: 100% (25228/25228), 113.01 MiB | 13.50 MiB/s, done.
Resolving deltas: 100% (15812/15812), done.
pi@RORPi:~ $ cd allsky
pi@RORPi:/allsky $ git checkout Point-Release-4
branch 'Point-Release-4' set up to track 'origin/Point-Release-4'.
Switched to a new branch 'Point-Release-4'
pi@RORPi:
/allsky $ ./install.sh

  • You need to TYPE 'yes' to continue the installation.
    This is to make sure you read it.

pi@RORPi:~/allsky $ ./install.sh

  • STARTING INSTALLATON AT Sat 21 Oct 16:11:24 BST 2023.

*** Welcome to the Allsky Installer! ***

  • ZWO camera found.
  • Using ZWO camera.
  • Size of current swap (100 MB) is sufficient; no change needed.
    mount: (hint) your fstab has been modified, but systemd still uses
    the old version; use 'systemctl daemon-reload' to reload.
  • /home/pi/allsky/tmp is now in memory.

*** NOTICE:

The following steps can take up to an hour depending on the speed of your Pi
and how many of the necessary dependencies are already installed.
You will see progress messages throughout the process.
At the end you will be prompted again for additional steps.

  • Installing the web server.
  • Installing dependencies.
  • Preparing Allsky commands.

*** ERROR:

Compile failed

  • The full log file is in /home/pi/allsky/config/installation_logs/make_all.log
    The end of the file is:
    Building capture_ZWO.o ...
    cc1plus: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
    make[1]: *** [Makefile:131: capture_ZWO.o] Error 1
    make[1]: Leaving directory '/home/pi/allsky/src'
    make: *** [Makefile:24: all] Error 2
  • ENDING INSTALLATON AT Sat 21 Oct 16:15:35 BST 2023.

Oops I am an idiot !!! The updates were in my fork of the release not in the allsky one !!!

I have just merged them and testing it now, I'll let you know shortly if its ok to try

@Alex-developer
Copy link
Collaborator

@Jonk2

I have sorted it now - Please try the install again

Sorry for the confusion - all my fault

Cheers

Alex

@Jonk2
Copy link

Jonk2 commented Oct 21, 2023

No worries, we're all idiots really!

I'll try again in a bit and let you know.

@Jonk2
Copy link

Jonk2 commented Nov 5, 2023

Gents, I've just installed the latest point-4 release (renaming allsky to allsk-OLD first, the previous point-4 release) and the installation script has reported an error copying the modules directory:

pi@RORPi:~/allsky $ git checkout Point-Release-4
branch 'Point-Release-4' set up to track 'origin/Point-Release-4'.
Switched to a new branch 'Point-Release-4'
pi@RORPi:~/allsky $ ./install.sh
* STARTING INSTALLATON AT Sun  5 Nov 21:19:49 GMT 2023.


********************************************************
*** Welcome to the Allsky Installer - v2023.05.01_04 ***
********************************************************

* ZWO camera found.
* Size of current swap (2048 MB) is sufficient; no change needed.
* /home/pi/allsky/tmp is currently a memory filesystem; no change needed.
mount: (hint) your fstab has been modified, but systemd still uses
       the old version; use 'systemctl daemon-reload' to reload.

*** NOTICE:
**********
The following steps can take up to an hour depending on the speed of your Pi
and how many of the necessary dependencies are already installed.
You will see progress messages throughout the process.
At the end you will be prompted again for additional steps.
**********

* Installing the web server.
* Installing dependencies.
* Preparing Allsky commands.
* Modifying locations for WebUI.
* Setting up WebUI options for ZWO cameras.
* Restoring camera-specific settings files:
*       settings_ZWO_ASI178MC.json
* Making new settings file '/home/pi/allsky/config/settings.json'.
* Executing makeChanges.sh --cameraTypeOnly  --debug 'cameraType' 'Camera Type' 'ZWO' 'ZWO'
* makeChanges.sh: cameraType: Old=[ZWO], New=[ZWO]
Calling capture_ZWO -cc_file '/home/pi/allsky/config/cc.json'
Calling: /home/pi/allsky/html/includes/createAllskyOptions.php --debug
        --cc_file /home/pi/allsky/config/cc.json
        --options_file /home/pi/allsky/config/options.json
        --settings_file /home/pi/allsky/config/settings.json
   Argument debug
cameraType=ZWO, cameraModel=ASI178MC
Camera-specific settings file exists (yes): /home/pi/allsky/config/settings_ZWO_ASI178MC.json.
Using existing /home/pi/allsky/config/settings_ZWO_ASI178MC.json.
Linking /home/pi/allsky/config/settings_ZWO_ASI178MC.json to /home/pi/allsky/config/settings.json.
* Settings files:
    -rw-rw-r-- 2 pi pi 2376 Oct 29 19:23 /home/pi/allsky/config/settings.json
    -rw-rw-r-- 2 pi pi 2376 Oct 29 19:23 /home/pi/allsky/config/settings_ZWO_ASI178MC.json
* Keeping 'en_GB.UTF-8' locale.
* Setting permissions on /var/log/allsky.log and /var/log/allskyperiodic.log.
* Installing PHP modules and dependencies.
* Installing python3-full libgfortran5 libopenblas0-pthread.
* Installing Python_dependencies for :
*    === Package #  1 of 15: [numpy>=1.25.0]
*    === Package #  2 of 15: [opencv-python<=4.7.0.72]
*    === Package #  3 of 15: [Pillow]
*    === Package #  4 of 15: [pyephem]
*    === Package #  5 of 15: [skyfield]
*    === Package #  6 of 15: [astral]
*    === Package #  7 of 15: [pytz]
*    === Package #  8 of 15: [scipy<=1.11.3]
*    === Package #  9 of 15: [paho-mqtt]
*    === Package # 10 of 15: [photutils]
*    === Package # 11 of 15: [astropy]
*    === Package # 12 of 15: [suncalc]
*    === Package # 13 of 15: [Adafruit-Blinka]
*    === Package # 14 of 15: [vcgencmd]
*    === Package # 15 of 15: [requests]
* Installing Trutype fonts.
* Setting up modules and overlays.
* Copying '/home/pi/allsky/config/overlay/config/overlay-ZWO.json' to 'overlay.json'.
* Restoring prior:
*     endOfNight_additionalSteps.sh: NO PRIOR VERSION
*     'images' directory
*     'darks' directory: NO PRIOR VERSION
*     'modules' directory
Traceback (most recent call last):
  File "/home/pi/allsky/scripts/flowupgrade.py", line 157, in <module>
    configManager.mergeConfigs()
  File "/home/pi/allsky/scripts/flowupgrade.py", line 140, in mergeConfigs
    self._processFile(file)
  File "/home/pi/allsky/scripts/flowupgrade.py", line 118, in _processFile
    currentJson = self._updateParams(oldJson, currentJson)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/allsky/scripts/flowupgrade.py", line 99, in _updateParams
    modObject = self._loadModule(currentJson[module]["module"])
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/allsky/scripts/flowupgrade.py", line 45, in _loadModule
    _temp = importlib.import_module(moduleName)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1206, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/pi/allsky/scripts/modules/allsky_loadimage.py", line 11, in <module>
    import allsky_shared as s
  File "/home/pi/allsky/scripts/modules/allsky_shared.py", line 15, in <module>
    import cv2
ModuleNotFoundError: No module named 'cv2'

*** ERROR:
**********
Copying 'modules' directory had problems.
**********

*     'overlay' directory
*     '/home/pi/allsky-OLD/config/overlay/extra' directory
*     WebUI security settings
*     'remote_configuration.json': NO PRIOR VERSION
*     'config.sh' file, as is
*         CONFIG_SH_VERSION=1, PRIOR=1
*     ftp-settings.sh, as is
*         FTP_SH_VERSION=1, PRIOR=1
* Updating some '/home/pi/allsky/config/config.sh' variables.
* Setting permissions on web-related files.
* Adding pi to www-data group.
addgroup: addgroup with two arguments is an unspecified operation.
* Creating/updating sudoers file.

* Installation is done and Allsky is ready to start.

* Enjoy Allsky!


* ENDING INSTALLATON AT Sun  5 Nov 21:26:19 GMT 2023.

pi@RORPi:~/allsky $

@Alex-developer
Copy link
Collaborator

I think I know what this is - I'll do a quick test

@Alex-developer
Copy link
Collaborator

Can you try the upgrade again please I have added a fix for this

@Jonk2
Copy link

Jonk2 commented Nov 8, 2023

Can you try the upgrade again please I have added a fix for this

I've had to wipe my drive and start afresh - I may have a hardware issue, so this means that I cannot try the fix until the next time there's a new test release.

If there is an issue when that time comes, I'll report back.

@Jonk2
Copy link

Jonk2 commented Nov 10, 2023

Right a little update.

I have confirmed (to myself at least) that my issues were caused by hardware, not software.

I have 2 RPI4s both with POE Hats and an M.2 SSD in an enclosure.

For months, the fixed PI has been running version 2023-05 and would lock me out (error 500, no SSH, no web access) but still appeared to be running. A hard power down to reboot was all I could do.

This would be random, day or night and sometimes once every 3 days, or sometimes up to 30 days.

I thought it may be the OS, so I changed it to boot to CLI only (no desktop). The PI ran for 3 months without issue. Then it crashed again, same issue.

The 2nd PI that I move between indoors and the ROR shed for testing new allskys etc, had the issue I mentioned before about the camera timeouts after installing bookworm lite and the latest point-4 allsky.

A shorter cable appeared to solve that. Since then, every reboot would take 5-10 minutes before I could do anything with it, and this past week, it wouldn't even obtain the server-set DHCP IP address, so I couldn't even access anything on the PI.

So....I decided to start afresh with a standard USB3 memory stick.

Since last night, I have had zero issues booting, multiple reboots, no camera timeouts (with the previously used longer cable I thought was the culprit), I can ssh in within a minute or so of booting, allsky is working perfectly fine, my scripts are running fine and am getting good results.

The issue (I'm fairly sure) was down to the M.2 SSD enclosure - I can only think that it is unstable, and probably drawing the limit of power, especially with a camera connected to USB3 too.

I am now very confident that allsky on bookworm lite 32Bit is running as intended, but I will monitor for the next week and let you know if I find anything else to discuss.

Here's a nice view from within my ROR whilst I concentrate the TEC140 on the Dumbell Nebula!

image

@EricClaeys
Copy link
Collaborator

@Jonk2 Jon, I also have a TEC 140 and love it. I use the Astro-Physics QUADTCC .7x reducer so the focal length is around 700 mm.

Glad to hear your setup is working well now. Thanks for the update.

@Jonk2
Copy link

Jonk2 commented Nov 11, 2023

@EricClaeys I also love my TEC140. It's about 17 years old, I bought it about 2 years ago and being in the UK, it was very rare to come up. I also got lucky and found an original TEC FF, so my FL is 1027mm.

Going back to allsky, yes it's good that this is now running exactly as it should. I've fixed my problem script and have some decent information displayed along with the image.

If I find anything else that's not playing ball with the bookworm lite I installed, I'll report back, but so far so good.

@Adler6907
Copy link

Hello,

I installed Allsky on a Pi5 64bit Bookworm (Camera = RPiHQ). The WebUI and the website work at first glance. But I haven't finished everything yet so that everything runs like my year-old system with 32bit Bullseye and the Pi4.

The allsky.log states that libgpiod cannot be loaded, which is not surprising since the GPIOS work completely differently on a Pi5.
https://blog.adafruit.com/2023/10/26/comparing-libgpiod-and-gpiozero-speeds-on-the-raspberry-pi-5/

It would be great if the installation script recognized the Pi5 and installed the correct settings for the GPIOs. Would it be possible?
Until then, can I manually install the correct libraries for the Pi5?

Thanks for an answer

CS Andreas

@EricClaeys
Copy link
Collaborator

@Adler6907, Andreas, I believe @Alex-developer is aware of the libgpiod issue and is using his Pi 5 to try and resolve it.

@Alex-developer
Copy link
Collaborator

Hello,

I installed Allsky on a Pi5 64bit Bookworm (Camera = RPiHQ). The WebUI and the website work at first glance. But I haven't finished everything yet so that everything runs like my year-old system with 32bit Bullseye and the Pi4.

The allsky.log states that libgpiod cannot be loaded, which is not surprising since the GPIOS work completely differently on a Pi5. https://blog.adafruit.com/2023/10/26/comparing-libgpiod-and-gpiozero-speeds-on-the-raspberry-pi-5/

It would be great if the installation script recognized the Pi5 and installed the correct settings for the GPIOs. Would it be possible? Until then, can I manually install the correct libraries for the Pi5?

Thanks for an answer

CS Andreas

Andreas

I am looking at this now. Unfortunately its not just a case of using different libraries as the pi5 has a whole new architecture around the RP1, as you mentioned.

I am going to convert all of the code to use the c libgpiod python bindings as its going to be far easier, at least I think it will !!!

I just need to confirm that all versions of the pi prior to the 5 use /dev/gpiochip0 for gpio access, the pi 5 use s/dev/gpiochip4

Cheers

Alex

@Adler6907
Copy link

Thank you for the quick answer and I will wait for the solution. If I can test something, please let me know.

@duckend
Copy link

duckend commented Nov 19, 2023

Just trying out this branch on a new Bookworm OS Lite (64bit install). (On an RPi 4)

No problems with the install script, but switching over to the overlay module didn't work. The legacy overlay disappeared as expected, but the overlay module text wasn't added to the image.

Looks like the problem was a missing library, as the log file showed the following at every capture

2023-11-19T14:52:44.026676+00:00 allsky allsky[921]: STARTING EXPOSURE at: 2023-11-19 14:52:44   @ 80.22 ms (0.08 sec)
2023-11-19T14:52:47.718795+00:00 allsky allsky[2062]: Traceback (most recent call last):
2023-11-19T14:52:47.719255+00:00 allsky allsky[2062]:   File "/home/iain/allsky/scripts/flow-runner.py", line 53, in <module>
2023-11-19T14:52:47.719519+00:00 allsky allsky[2062]:     import allsky_shared as shared
2023-11-19T14:52:47.719748+00:00 allsky allsky[2062]:   File "/home/iain/allsky/scripts/modules/allsky_shared.py", line 21, in <module>
2023-11-19T14:52:47.719864+00:00 allsky allsky[2062]:     import board
2023-11-19T14:52:47.719952+00:00 allsky allsky[2062]:   File "/home/iain/allsky/venv/lib/python3.11/site-packages/board.py", line 45, in <module>
2023-11-19T14:52:47.720042+00:00 allsky allsky[2062]:     from adafruit_blinka.board.raspberrypi.raspi_4b import *
2023-11-19T14:52:47.720124+00:00 allsky allsky[2062]:   File "/home/iain/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/board/raspberrypi/raspi_4b.py", line 6, in <module>
2023-11-19T14:52:47.720200+00:00 allsky allsky[2062]:     from adafruit_blinka.microcontroller.bcm2711 import pin
2023-11-19T14:52:47.720411+00:00 allsky allsky[2062]:   File "/home/iain/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/microcontroller/bcm2711/pin.py", line 5, in <module>
2023-11-19T14:52:47.720546+00:00 allsky allsky[2062]:     from RPi import GPIO
2023-11-19T14:52:47.720634+00:00 allsky allsky[2062]: ModuleNotFoundError: No module named 'RPi'
2023-11-19T14:53:15.306784+00:00 allsky allsky[921]: STARTING EXPOSURE at: 2023-11-19 14:53:15   @ 68.50 ms (0.07 sec)

After manually adding RPi.GPIO via the following, all then worked as expected, overlays started appearing and the errors stopped.

iain@allsky:~ $ source ~/allsky/venv/bin/activate
(venv) iain@allsky:~ $ pip3 install RPi.GPIO
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting RPi.GPIO
  Downloading RPi.GPIO-0.7.1.tar.gz (29 kB)
  Preparing metadata (setup.py) ... done
Installing collected packages: RPi.GPIO
  DEPRECATION: RPi.GPIO is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
  Running setup.py install for RPi.GPIO ... done
Successfully installed RPi.GPIO-0.7.1
(venv) iain@allsky:~ $ deactivate

Camera is a ZWO device in case that affects any paths the installer may take.

Hope this helps
Iain

@EricClaeys
Copy link
Collaborator

@Alex-developer, any thoughts?

@duckend
Copy link

duckend commented Nov 19, 2023

I may have noticed a typo in upload.sh in this branch which doesn't appear in master.

I've set up a remote web server and am using scp to transfer the files, however the initial file upload check which is part of the website/install.sh process was failing as it was attempting to upload to the root / folder instead of the folder specified in IMAGE_DIR.

Looks like the scp command in upload.sh (approx line 160) is set up to use ${DIRECTORY} instead of ${REMOTE_DIR}.

Changing the above permitted the install.sh to complete its pre-flight checks and all now working well.

elif [[ "${PROTOCOL}" == "scp" ]] ; then
	#shellcheck disable=SC2153
	DEST="${REMOTE_USER}@${REMOTE_HOST}:${DIRECTORY}/${DESTINATION_NAME}"
	if [[ ${SILENT} == "false" && ${ALLSKY_DEBUG_LEVEL} -ge 3 ]]; then
		echo "${ME}: Copying ${FILE_TO_UPLOAD} to ${DEST}"
	fi

@EricClaeys
Copy link
Collaborator

Yikes! Good catch.
I was updating this file and one from a newer release and apparently put in the wrong changes.
Thanks for letting me know.

@EricClaeys
Copy link
Collaborator

@duckend, I fixed this in Point Release 4 (which is NOT ready to be used yet). To fix, replace all occurrences of REMOTE_DIR with DIRECTORY. There are about 10.
Thanks again.

@Alex-developer
Copy link
Collaborator

Just trying out this branch on a new Bookworm OS Lite (64bit install). (On an RPi 4)

No problems with the install script, but switching over to the overlay module didn't work. The legacy overlay disappeared as expected, but the overlay module text wasn't added to the image.

Looks like the problem was a missing library, as the log file showed the following at every capture

2023-11-19T14:52:44.026676+00:00 allsky allsky[921]: STARTING EXPOSURE at: 2023-11-19 14:52:44   @ 80.22 ms (0.08 sec)
2023-11-19T14:52:47.718795+00:00 allsky allsky[2062]: Traceback (most recent call last):
2023-11-19T14:52:47.719255+00:00 allsky allsky[2062]:   File "/home/iain/allsky/scripts/flow-runner.py", line 53, in <module>
2023-11-19T14:52:47.719519+00:00 allsky allsky[2062]:     import allsky_shared as shared
2023-11-19T14:52:47.719748+00:00 allsky allsky[2062]:   File "/home/iain/allsky/scripts/modules/allsky_shared.py", line 21, in <module>
2023-11-19T14:52:47.719864+00:00 allsky allsky[2062]:     import board
2023-11-19T14:52:47.719952+00:00 allsky allsky[2062]:   File "/home/iain/allsky/venv/lib/python3.11/site-packages/board.py", line 45, in <module>
2023-11-19T14:52:47.720042+00:00 allsky allsky[2062]:     from adafruit_blinka.board.raspberrypi.raspi_4b import *
2023-11-19T14:52:47.720124+00:00 allsky allsky[2062]:   File "/home/iain/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/board/raspberrypi/raspi_4b.py", line 6, in <module>
2023-11-19T14:52:47.720200+00:00 allsky allsky[2062]:     from adafruit_blinka.microcontroller.bcm2711 import pin
2023-11-19T14:52:47.720411+00:00 allsky allsky[2062]:   File "/home/iain/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/microcontroller/bcm2711/pin.py", line 5, in <module>
2023-11-19T14:52:47.720546+00:00 allsky allsky[2062]:     from RPi import GPIO
2023-11-19T14:52:47.720634+00:00 allsky allsky[2062]: ModuleNotFoundError: No module named 'RPi'
2023-11-19T14:53:15.306784+00:00 allsky allsky[921]: STARTING EXPOSURE at: 2023-11-19 14:53:15   @ 68.50 ms (0.07 sec)

After manually adding RPi.GPIO via the following, all then worked as expected, overlays started appearing and the errors stopped.

iain@allsky:~ $ source ~/allsky/venv/bin/activate
(venv) iain@allsky:~ $ pip3 install RPi.GPIO
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting RPi.GPIO
  Downloading RPi.GPIO-0.7.1.tar.gz (29 kB)
  Preparing metadata (setup.py) ... done
Installing collected packages: RPi.GPIO
  DEPRECATION: RPi.GPIO is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
  Running setup.py install for RPi.GPIO ... done
Successfully installed RPi.GPIO-0.7.1
(venv) iain@allsky:~ $ deactivate

Camera is a ZWO device in case that affects any paths the installer may take.

Hope this helps Iain

I have just installed pR4 on Bookworm and tested the basic GPIO functions using a DHT22 and a relay - All works fine. If you can could you reinstall Allsky, preferably on a clean card? To get PR4 to install you will need to remove the 'exit' command towards the top of the install.sh script

I have not had chance to test the pi5 yet but will do so over the next few days

@Adler6907
Copy link

I had a small problem with the latitude and longitude in controller.js.

In install.sh, line 1596 or 1601 states as an example that you can specify the direction of the compass without spaces after the number N or S (e.g., 20.1S).

In controller.js (lines 221, 223,254 and 256), in the case of a string, 2 characters are removed from the end in the conversion functions sc.latitude = lat.substr(0, len-2) * 1;

Either you have to specify a space in configuration.json during installation or you change the code in the conversion functions to ...len-1...

@duckend
Copy link

duckend commented Dec 7, 2023

I have just installed pR4 on Bookworm and tested the basic GPIO functions using a DHT22 and a relay - All works fine. If you can could you reinstall Allsky, preferably on a clean card? To get PR4 to install you will need to remove the 'exit' command towards the top of the install.sh script

I'm hoping to work on the camera at the weekend, I have a spare card so will try a new install. Is there an install log saved anywhere that I can share when complete?

@Alex-developer
Copy link
Collaborator

I have just installed pR4 on Bookworm and tested the basic GPIO functions using a DHT22 and a relay - All works fine. If you can could you reinstall Allsky, preferably on a clean card? To get PR4 to install you will need to remove the 'exit' command towards the top of the install.sh script

I'm hoping to work on the camera at the weekend, I have a spare card so will try a new install. Is there an install log saved anywhere that I can share when complete?

Yes there is an install log in ~/allsky/config/installation_log

If you intend to install the extra modules then please make sure you use the dev branch and not the master branch

@EricClaeys
Copy link
Collaborator

@Adler6907, I think it's correct as is. If lat is 20.1S the "len" is 5. Subtract 2 is 3. The first item in an array or string is the 0'th item so we want characters 0 (2), 1 (0), 2 (.), and 3 (1).

@EricClaeys
Copy link
Collaborator

@duckend, @Alex-developer, the dev branch is not ready for use. It has the combined config file and the included local Website and I have never tested installation so doubt it will install.

@Adler6907
Copy link

Adler6907 commented Dec 8, 2023

@EricClaeys,
correct we want 4 characters out of 5 :-)
substr is defined with substr(start,length) and not with substr(startpos,endpos) -> https://www.javatpoint.com/javascript-string-substr-method
The debugger (Chrome) agrees with me too ;-)


@Alex-developer
I tried to remove the repeating error on a Pi5. Unfortunately still without success :-/

2023-12-08T08:33:52.961557+01:00 allsky1 allskperiodic[2606]: Traceback (most recent call last):
2023-12-08T08:33:52.961672+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/scripts/flow-runner.py", line 53, in <module>
2023-12-08T08:33:52.961731+01:00 allsky1 allskperiodic[2606]:     import allsky_shared as shared
2023-12-08T08:33:52.961754+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/scripts/modules/allsky_shared.py", line 21, in <module>
2023-12-08T08:33:52.961775+01:00 allsky1 allskperiodic[2606]:     import board
2023-12-08T08:33:52.961798+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/venv/lib/python3.11/site-packages/board.py", line 47, in <module>
2023-12-08T08:33:52.961820+01:00 allsky1 allskperiodic[2606]:     from adafruit_blinka.board.raspberrypi.raspi_5b import *
2023-12-08T08:33:52.961843+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/board/raspberrypi/raspi_5b.py", line 6, in <module>
2023-12-08T08:33:52.961864+01:00 allsky1 allskperiodic[2606]:     from adafruit_blinka.microcontroller.bcm2712 import pin
2023-12-08T08:33:52.961883+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/microcontroller/bcm2712/pin.py", line 8, in <module>
2023-12-08T08:33:52.961903+01:00 allsky1 allskperiodic[2606]:     D0 = Pin((4, 0))
2023-12-08T08:33:52.961921+01:00 allsky1 allskperiodic[2606]:          ^^^^^^^^^^^
2023-12-08T08:33:52.961941+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/microcontroller/generic_linux/libgpiod_pin.py", line 36, in __init__
2023-12-08T08:33:52.961960+01:00 allsky1 allskperiodic[2606]:     self._chip = gpiod.Chip(str(pin_id[0]), gpiod.Chip.OPEN_BY_NUMBER)
2023-12-08T08:33:52.961982+01:00 allsky1 allskperiodic[2606]:                                             ^^^^^^^^^^^^^^^^^^^^^^^^^
2023-12-08T08:33:52.962001+01:00 allsky1 allskperiodic[2606]: AttributeError: type object 'Chip' has no attribute 'OPEN_BY_NUMBER'

I'm probably not alone with this problem
adafruit/Adafruit_Blinka#740


In the file /home/pi/allsky/html/includes/system.php you could include the Pi5 in the RPiVersion() function. e.g.

'c04170' => 'Raspberry Pi 5 Model B Rev 1.0 (4 GB)',
'd04170' => 'Raspberry Pi 5 Model B Rev 1.0 (8 GB)'

@Alex-developer
Copy link
Collaborator

@duckend, @Alex-developer, the dev branch is not ready for use. It has the combined config file and the included local Website and I have never tested installation so doubt it will install.

I am talking about the extra modules dev branch

@Alex-developer
Copy link
Collaborator

@EricClaeys, correct we want 4 characters out of 5 :-) substr is defined with substr(start,length) and not with substr(startpos,endpos) -> https://www.javatpoint.com/javascript-string-substr-method The debugger (Chrome) agrees with me too ;-)

@Alex-developer I tried to remove the repeating error on a Pi5. Unfortunately still without success :-/

2023-12-08T08:33:52.961557+01:00 allsky1 allskperiodic[2606]: Traceback (most recent call last):
2023-12-08T08:33:52.961672+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/scripts/flow-runner.py", line 53, in <module>
2023-12-08T08:33:52.961731+01:00 allsky1 allskperiodic[2606]:     import allsky_shared as shared
2023-12-08T08:33:52.961754+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/scripts/modules/allsky_shared.py", line 21, in <module>
2023-12-08T08:33:52.961775+01:00 allsky1 allskperiodic[2606]:     import board
2023-12-08T08:33:52.961798+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/venv/lib/python3.11/site-packages/board.py", line 47, in <module>
2023-12-08T08:33:52.961820+01:00 allsky1 allskperiodic[2606]:     from adafruit_blinka.board.raspberrypi.raspi_5b import *
2023-12-08T08:33:52.961843+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/board/raspberrypi/raspi_5b.py", line 6, in <module>
2023-12-08T08:33:52.961864+01:00 allsky1 allskperiodic[2606]:     from adafruit_blinka.microcontroller.bcm2712 import pin
2023-12-08T08:33:52.961883+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/microcontroller/bcm2712/pin.py", line 8, in <module>
2023-12-08T08:33:52.961903+01:00 allsky1 allskperiodic[2606]:     D0 = Pin((4, 0))
2023-12-08T08:33:52.961921+01:00 allsky1 allskperiodic[2606]:          ^^^^^^^^^^^
2023-12-08T08:33:52.961941+01:00 allsky1 allskperiodic[2606]:   File "/home/pi/allsky/venv/lib/python3.11/site-packages/adafruit_blinka/microcontroller/generic_linux/libgpiod_pin.py", line 36, in __init__
2023-12-08T08:33:52.961960+01:00 allsky1 allskperiodic[2606]:     self._chip = gpiod.Chip(str(pin_id[0]), gpiod.Chip.OPEN_BY_NUMBER)
2023-12-08T08:33:52.961982+01:00 allsky1 allskperiodic[2606]:                                             ^^^^^^^^^^^^^^^^^^^^^^^^^
2023-12-08T08:33:52.962001+01:00 allsky1 allskperiodic[2606]: AttributeError: type object 'Chip' has no attribute 'OPEN_BY_NUMBER'

I'm probably not alone with this problem adafruit/Adafruit_Blinka#740

In the file /home/pi/allsky/html/includes/system.php you could include the Pi5 in the RPiVersion() function. e.g.

'c04170' => 'Raspberry Pi 5 Model B Rev 1.0 (4 GB)',
'd04170' => 'Raspberry Pi 5 Model B Rev 1.0 (8 GB)'

The pi 5 is still broken, Adafruit don't seem to accept its an issue !. I am only testing on the pi 4 at the moment

@EricClaeys
Copy link
Collaborator

EricClaeys commented Dec 8, 2023

@Adler6907, can you think of a better way to get info on the Pi rather than using those codes? They are an administrative headache sine the list keeps growing.

The info we want is the model (3B, 4B, etc.) and ideally the memory and Rev. We can determine the memory at run time but I have no idea how to determine the Rev without using those codes.

@Adler6907, @Alex-developer, can you think of any reason why we should NOT set the Computer field at installation per the above comments, then make the field read-only so we have consistency? That field is only used for display purposes in the WebUI and Allsky Website; we don't make any decisions based on it.

UPDATE:
Moved this bug discussion to Issue #3165

@EricClaeys
Copy link
Collaborator

@Adler6907, please see my reply at the end of Issue 3161.
Keep it up.

@EricClaeys
Copy link
Collaborator

I'm locking this Discussion item. It's getting pretty long and no longer just related to Bookworm.
I moved a couple of the topics to new Issues. Let's please create new Issues for new bugs or new Discussion items for general questions/comments.

Keep the ideas coming - they help improve Allsky!!

@AllskyTeam AllskyTeam locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Need user response Waiting for user to respond
Projects
None yet
Development

No branches or pull requests

9 participants