Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extratextage = 0 never displays extra text iso always #271

Closed
JosWennmacker opened this issue Oct 8, 2020 · 5 comments
Closed

Extratextage = 0 never displays extra text iso always #271

JosWennmacker opened this issue Oct 8, 2020 · 5 comments

Comments

@JosWennmacker
Copy link

Setting "extratextage":"0", shuold always display extratext but it just does not display extratext at all.

@thomasjacquin
Copy link
Collaborator

In case it's not a fresh install, have you recompiled the capture binary?
make capture

@JosWennmacker
Copy link
Author

It's a fresh install. Downloaded and installed on October 7. (make capture says: make: 'capture' is op to date.).

@Alex-developer
Copy link
Collaborator

Its a bug :-(

I'll fix it and do a PR. If you are comfortable editing the code find the following lines in capture.cpp

                                } else {
                                    displayDebugText("Extra Text File Age Disabled So Displaying Anyway\n", 1);
                                }

And change it to

                                } else {
                                    displayDebugText("Extra Text File Age Disabled So Displaying Anyway\n", 1);
                                    bAddExtra = true;
                                }

@JosWennmacker
Copy link
Author

Applied patch. Made capture. Succes! Thank you!

@Alex-developer
Copy link
Collaborator

Applied patch. Made capture. Succes! Thank you!

Glad it worked - I have fixed it in the main code just waiting for Thomas to approve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants