Skip to content

Commit 23efd89

Browse files
Merge pull request #3335 from AllskyTeam/3317-bug-if-a-field-is-outside-the-image-nothing-is-indicated-in-overlay-manager
3317 Fixes for off screen fields
2 parents 3b58033 + 158f17e commit 23efd89

File tree

9 files changed

+236
-2672
lines changed

9 files changed

+236
-2672
lines changed
1.19 KB
Loading

html/documentation/overlays/overlays.html

+11-1
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,7 @@ <h2>The Overlay Editor User Interface</h2>
846846
<tr>
847847
<td class="moduleAnnotation">
848848
<span class="moduleToolbarIconNumber">14</span>
849-
Working Area
849+
<span class="moduleToolbar">Working Area</span>
850850
</td>
851851
<td></td>
852852
<td>
@@ -864,6 +864,16 @@ <h2>The Overlay Editor User Interface</h2>
864864
</blockquote>
865865
</td>
866866
</tr>
867+
<tr>
868+
<td class="moduleAnnotation">
869+
<span class="moduleToolbarIconNumber">15</span>
870+
<span class="moduleToolbar">Field Errors</span>
871+
</td>
872+
<td class="overlayIcon"><i class="fa fa-solid fa-circle-exclamation fa-lg"></i></td>
873+
<td>
874+
<p><strong>Only</strong> displayed if any fields are detected that are off off the screen. Selecting this icon will display a dialog allowing the off screen fields to be deleted or fixed. Fixing the field will move it into the visible portion of the overlay editor allowing you to move it to the exact position required.</p>
875+
</td>
876+
</tr>
867877
</tbody>
868878
</table>
869879
<hr class="separatorSmall">

html/includes/overlay.php

+33
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,11 @@ function DisplayOverlay($image_name)
112112
<li>
113113
<div class="btn btn-lg navbar-btn oe-zoom" id="oe-zoom-fit" data-toggle="tooltip" data-container="body" data-placement="top" title="Fit to Window"><i class="fa-solid fa-down-left-and-up-right-to-center"></i></div>
114114
</li>
115+
<li>
116+
<div class="btn btn-lg navbar-btn oe-field-errors hidden" id="oe-field-errors" data-toggle="tooltip" data-container="body" data-placement="top" title="Display Field Errors">
117+
<i class="fa-solid fa-circle-exclamation"></i>
118+
</div>
119+
</li>
115120
</ul>
116121
<ul class="nav navbar-nav navbar-right">
117122
<li id="oe-toolbar-debug" class="hidden">
@@ -220,6 +225,34 @@ function DisplayOverlay($image_name)
220225
</table>
221226
</div>
222227

228+
<div class="modal" role="dialog" id="oe-field-errors-dialog">
229+
<div class="modal-dialog modal-lg" role="document">
230+
<div class="modal-content">
231+
<div class="modal-header">
232+
<button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
233+
<h4 class="modal-title">Field Errors</h4>
234+
</div>
235+
<div class="modal-body">
236+
<div role="tabpanel" class="tab-pane active" id="oe-field-errors-dialog-fields">
237+
<table id="fielderrorstable" class="display compact" style="width:98%">
238+
<thead>
239+
<tr>
240+
<th>Id</th>
241+
<th>Field Name</th>
242+
<th>Type</th>
243+
<th>&nbsp;</th>
244+
</tr>
245+
</thead>
246+
</table>
247+
</div>
248+
</div>
249+
<div class="modal-footer">
250+
<button type="button" class="btn btn-default" id="oe-field-errors-dialog-close">Close</button>
251+
</div>
252+
</div>
253+
</div>
254+
</div>
255+
223256
<div class="modal" role="dialog" id="oe-item-list-dialog">
224257
<div class="modal-dialog modal-lg" role="document">
225258
<div class="modal-content">

0 commit comments

Comments
 (0)