Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont trap exceptions at debug level 4 #4074

Open
Alex-developer opened this issue Nov 30, 2024 · 1 comment
Open

Dont trap exceptions at debug level 4 #4074

Alex-developer opened this issue Nov 30, 2024 · 1 comment
Assignees
Labels
enhancement In testing Change being tested by the Allsky team

Comments

@Alex-developer
Copy link
Collaborator

When level 4 is set dont catch errors in flow-runner.py

This will make it easier to see problems

@Alex-developer Alex-developer added this to the v2024.12.06_01 milestone Nov 30, 2024
@Alex-developer Alex-developer self-assigned this Nov 30, 2024
@Alex-developer Alex-developer transferred this issue from AllskyTeam/allsky-modules Dec 14, 2024
@Alex-developer Alex-developer added the In progress Change in progress label Dec 19, 2024
Alex-developer added a commit that referenced this issue Dec 19, 2024
…-debug-level-4

#4074 Don't trap errors at log level 4
@Alex-developer Alex-developer added In testing Change being tested by the Allsky team and removed In progress Change in progress labels Dec 19, 2024
@Alex-developer
Copy link
Collaborator Author

When debug level 4 is set the flow runner will not trap any exceptions thrown in modules. This make sit far easier to find issues

To test. Set the debug level to 4 and then introduce a deliberate exception in a module. Best way is to add something like

a = 5 / 0

in the main module code to force a division by zero error.

When level 4 is set the exception will be in the allsky.log or allskyperiodic.log

When any other level is set the exception will be trapped and reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement In testing Change being tested by the Allsky team
Projects
None yet
Development

No branches or pull requests

1 participant