Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dashboard shown when PUBLIC_CHECK_VERSION_ON_GITHUB is not set #12

Open
Jbekker opened this issue Aug 7, 2023 · 1 comment
Open

Comments

@Jbekker
Copy link

Jbekker commented Aug 7, 2023

When PUBLIC_CHECK_VERSION_ON_GITHUB is not set, an uncaught exception occurs in src\lib\helpers\env.ts. That prevents the dashboard from displaying at all.

Uncaught SyntaxError SyntaxError: "undefined" is not valid JSON
at envBool (d:\projects\alloctrl\src\lib\helpers\env.ts:3:24)
at select_block_type (d:\projects\alloctrl\src\routes+page.svelte:17:8)
at create_fragment (localhost꞉5173/src/routes/+page.svelte:142:29)

It could make sense to do something like this to prevent this scenario:
return Boolean( JSON.parse( value ?? false ));

@ctibo
Copy link
Contributor

ctibo commented Aug 10, 2023

I'll fix this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants