feat: rename and export LegacyAlfrescoApi in public-api (#1382)

* feat: rename and export LegacyAlfrescoApi in public-api

index.ts

@@ -18,6 +18,7 @@
 export * from './src/api-legacy/legacy';
 export * from './src/api-legacy/content-rest-api/src/index';
 export * from './src/api-legacy/activiti-rest-api/src/index';
+export * from './src/api-legacy/legacy-alfresco-api';
 export * from './src/api/content-rest-api/index';
 export * from './src/api/content-custom-api/index';
 export * from './src/api/discovery-rest-api/index';

src/alfrescoApi.ts

@@ -24,10 +24,10 @@ import { ProcessClient } from './processClient';
 import { Storage } from './storage';
 import { AlfrescoApiConfig } from './alfrescoApiConfig';
 import { Authentication } from './authentication/authentication';
-import { LegacyAlfrescoApiHelper } from './to-deprecate/legacy-alfresco-api.helper';
+import { LegacyAlfrescoApi } from './api-legacy/legacy-alfresco-api';
 import { AlfrescoApiType } from './to-deprecate/alfresco-api-type';
 
-export class AlfrescoApi extends LegacyAlfrescoApiHelper implements Emitter, AlfrescoApiType {
+export class AlfrescoApi extends LegacyAlfrescoApi implements Emitter, AlfrescoApiType {
     storage: Storage;
     config: AlfrescoApiConfig;
     contentClient: ContentClient;

src/api-clients/api-client.ts

@@ -16,7 +16,7 @@
 */
 
 import { AlfrescoApiType } from "../to-deprecate/alfresco-api-type";
-import { LegacyAlfrescoApiHelper } from "../to-deprecate/legacy-alfresco-api.helper";
+import { LegacyAlfrescoApi } from "../api-legacy/legacy-alfresco-api";
 import { HttpClient, RequestOptions } from "./http-client.interface";
 
 export abstract class ApiClient {
@@ -32,7 +32,7 @@ export abstract class ApiClient {
     constructor(httpClient: HttpClient);
     constructor(httpClient?: AlfrescoApiType | HttpClient) {
         // TODO: remove legacyApi?: AlfrescoApi option and clean up this code. BREAKING CHANGE!
-        if (httpClient instanceof LegacyAlfrescoApiHelper) {
+        if (httpClient instanceof LegacyAlfrescoApi) {
             this.alfrescoApi = httpClient as AlfrescoApiType;
         } else {
             this.httpClient = httpClient as HttpClient;

src/api-legacy/legacy-alfresco-api.ts

@@ -0,0 +1,20 @@
+/*!
+ * @license
+ * Copyright 2018 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Empty class exist only to help differentiate with HttpClient interface
+// and "instance of" LegacyAlfrescoApi and to break existing circular deps
+export class LegacyAlfrescoApi {}