Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile-Guided Optimization (PGO) benchmark report #152

Open
zamazan4ik opened this issue Sep 17, 2024 · 1 comment
Open

Profile-Guided Optimization (PGO) benchmark report #152

zamazan4ik opened this issue Sep 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@zamazan4ik
Copy link

Hi!

As I have done many times before, I decided to test the Profile-Guided Optimization (PGO) technique to optimize the library performance. For reference, results for other projects are available at https://github.com/zamazan4ik/awesome-pgo . Since PGO helped a lot for many libraries, I decided to apply it to rust-lexical to see if the performance win (or lose) can be achieved. Here are my benchmark results.

This information can be interesting for anyone who wants to achieve more performance with the library in their use cases.

Test environment

  • Fedora 40
  • Linux kernel 6.10.9
  • AMD Ryzen 9 5900x
  • 48 Gib RAM
  • SSD Samsung 980 Pro 2 Tib
  • Compiler - Rustc 1.81.0
  • rust-lexical version: main branch on commit aeab32205c18c4569402f83817eeb9fb983ee64b
  • Disabled Turbo boost

Benchmark

For benchmark purposes, I use built-in into the project benchmarks. For PGO optimization I use cargo-pgo tool. Release bench results I got with taskset -c 0 cargo bench command. The PGO training phase is done with taskset -c 0 cargo pgo bench, PGO optimization phase - with taskset -c 0 cargo pgo optimize bench.

taskset -c 0 is used for reducing the OS scheduler's influence on the results. All measurements are done on the same machine, with the same background "noise" (as much as I can guarantee).

However, I don't know how the project benchmarks is good for now due to #148 - I don't have enough knowledge about it (yet).

Results

I got the following results:

According to the results, we see improvements in many cases. However, some cases are also regressed. This can come from conflicting workloads in the bench quite where optimization in one place pessimizes other places - it sometimes happens with PGO. This information is still useful if users have some specific workloads for rust-lexical and don't have such conflicts.

Further steps

At the very least, the library's users can find this performance report and decide to enable PGO for their applications if they care about rust-lexical performance in their workloads. Maybe a small note somewhere in the documentation (the README file?) will be enough to raise awareness about this work. Another way - try to figure out the root cause of performance differences between PGO and non-PGO library versions, and, probably, try to tweak the library sources a bit more - however this way also requires some time to analyze the resulting LLVM IR/assembly differences between them.

Also, Post-Link Optimization (PLO) can be tested after PGO. It can be done by applying tools like LLVM BOLT to applications with apps that use rust-lexical. However, it's a much less mature optimization technique compared to PGO.

Thank you.

P.S. It's just a benchmark report, not a bug. Probably Discussions is a better place to put such things but they are disabled for the repo for now.

@Alexhuszagh Alexhuszagh added this to the 1.1 milestone Sep 17, 2024
@Alexhuszagh Alexhuszagh added enhancement New feature or request good first issue Good for newcomers labels Sep 17, 2024
@Alexhuszagh Alexhuszagh self-assigned this Sep 17, 2024
@Alexhuszagh
Copy link
Owner

This is wonderful, I'll make this a priority and take a careful look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants